hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18170) Refactor ReplicationSourceWALReaderThread
Date Sat, 17 Jun 2017 02:51:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052649#comment-16052649
] 

Ted Yu commented on HBASE-18170:
--------------------------------

{code}
+        + ".replicationSource.replicationWALReaderThread." + walGroupId + "," + peerClusterZnode,
{code}
Can the thread name be shorter ? e.g. replicationWALReaderThread -> wal-reader
{code}
+public class RecoveredReplicationSourceWALReaderThread extends ReplicationSourceWALReaderThread
{
{code}
Add javadoc for the class.

For ReplicationSourceInterface, is the import of WALEntryFilter used ?



> Refactor ReplicationSourceWALReaderThread
> -----------------------------------------
>
>                 Key: HBASE-18170
>                 URL: https://issues.apache.org/jira/browse/HBASE-18170
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>         Attachments: HBASE-18170.master.001.patch, HBASE-18170.master.001.patch, HBASE-18170.master.002.patch,
HBASE-18170.master.002.patch, HBASE-18170.master.003.patch
>
>
> HBASE-18130 add some get* method to ReplicationSource. So ReplicationSourceWALReaderThread
doesn't need so many parameter to initialize. And the WALEntryFilter only used by ReplicationSourceWALReaderThread,
so we don't need to new it for every ReplicationSourceWALReaderThread. Meanwhile, we can separate
a new RecoveredReplicationSourceWALReaderThread for recovered replication source. Thanks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message