hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18169) Remove the methods in IA.LimitedPrivate interfaces which are not useful for CP
Date Wed, 07 Jun 2017 11:19:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040718#comment-16040718

Anoop Sam John commented on HBASE-18169:

My concern is this.
You can see that in Region there are exposed methods like startRegionOp.  The javadoc says
for normal region ops, this has to be called first. But that is for our internal use.  I mean
if a CP user call directly put or so on Region, there is no need to call this API. Within
put, we do that.  So these will just confuse the CP users..  CP users doing puts or gets on
their own is a possible use case.  
Even from day one, there are many calls to region APIs by type casting to (HRegion) . You
can see that in many code areas.
Again IMO how we best do this is an impl headache which should not come in when we do cleaning
up of these interfaces. Agree that the impl also we should do in a clean way.

> Remove the methods in IA.LimitedPrivate interfaces which are not useful for CP
> ------------------------------------------------------------------------------
>                 Key: HBASE-18169
>                 URL: https://issues.apache.org/jira/browse/HBASE-18169
>             Project: HBase
>          Issue Type: Improvement
>          Components: Coprocessors
>            Reporter: Duo Zhang
>            Priority: Critical
>             Fix For: 2.0.0
> As discussed in HBASE-18038. In RegionServerServices, Region and StoreFile interfaces
we expose too many unnecessary methods. We need to find a way to not expose these methods
to CP.

This message was sent by Atlassian JIRA

View raw message