hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18160) Fix incorrect logic in FilterList.filterKeyValue
Date Fri, 09 Jun 2017 07:39:19 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044092#comment-16044092
] 

Hadoop QA commented on HBASE-18160:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue}
Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 9s {color} | {color:red}
HBASE-18160 does not apply to branch-1.1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12872214/HBASE-18160.branch-1.1.v1.patch
|
| JIRA Issue | HBASE-18160 |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/7157/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Fix incorrect  logic in FilterList.filterKeyValue
> -------------------------------------------------
>
>                 Key: HBASE-18160
>                 URL: https://issues.apache.org/jira/browse/HBASE-18160
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>         Attachments: HBASE-18160.branch-1.1.v1.patch, HBASE-18160.branch-1.v1.patch,
HBASE-18160.v1.patch, HBASE-18160.v2.patch, HBASE-18160.v2.patch
>
>
> As HBASE-17678 said, there are two problems in FilterList.filterKeyValue implementation:

> 1.  FilterList did not consider INCLUDE_AND_SEEK_NEXT_ROW case( seems like INCLUDE_AND_SEEK_NEXT_ROW
is a newly added case, and the dev forgot to consider FilterList), So if a user use INCLUDE_AND_SEEK_NEXT_ROW
in his own Filter and wrapped by a FilterList,  it'll  throw  an IllegalStateException("Received
code is not valid."). 
> 2.  For FilterList with MUST_PASS_ONE,   if filter-A in filter list return  INCLUDE and
filter-B in filter list return INCLUDE_AND_NEXT_COL,   the FilterList will return  INCLUDE_AND_NEXT_COL
finally.  According to the mininal step rule , It's incorrect.  (filter list with MUST_PASS_ONE
choose the mininal step among filters in filter list. Let's call it: The Mininal Step Rule).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message