hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Harju (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18023) Log multi-* requests for more than threshold number of rows
Date Thu, 15 Jun 2017 23:40:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051205#comment-16051205

David Harju commented on HBASE-18023:

Thanks [~elserj]!

Good suggestions, I'll work to implement them and then post a new patch.

I added the "(See https://issues.apache.org/jira/browse/HBASE-18023)" reference in response
to [~stack]'s suggestion to add to the log line, "...a pointer to doc or issue on why many
small batches will go down better than a few massive ones".  If there's a better doc or issue
to reference I can replace it but otherwise I can remove the reference altogether.

As for the mocking suggestion at the bottom, I was resistant to expanding / creating any new
public methods for objects in the patch (which I may need to do in order to do the mock verification
you suggest), which is why I went with the more brittle verification you saw, but there does
seem to be precedent in the code for creating methods for testing purposes only so I'll go
ahead and make those "for testing purposes only" public access points (either public methods
delivering the logging string or a public ctor for RSRpcServices which takes in some kind
of logging delegate).

> Log multi-* requests for more than threshold number of rows
> -----------------------------------------------------------
>                 Key: HBASE-18023
>                 URL: https://issues.apache.org/jira/browse/HBASE-18023
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Clay B.
>            Assignee: David Harju
>            Priority: Minor
>         Attachments: HBASE-18023.master.001.patch
> Today, if a user happens to do something like a large multi-put, they can get through
request throttling (e.g. it is one request) but still crash a region server with a garbage
storm. We have seen regionservers hit this issue and it is silent and deadly. The RS will
report nothing more than a mysterious garbage collection and exit out.
> Ideally, we could report a large multi-* request before starting it, in case it happens
to be deadly. Knowing the client, user and how many rows are affected would be a good start
to tracking down painful users.

This message was sent by Atlassian JIRA

View raw message