hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17537) Remove Queue#isAvailable() since we have waits/wakes after HBASE-17067
Date Sat, 03 Jun 2017 02:10:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035762#comment-16035762
] 

stack commented on HBASE-17537:
-------------------------------

Ok. Fails like this:

{code}
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler
Tests run: 23, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 3.609 sec <<< FAILURE!
- in org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler
testVerifyNamespaceXLock(org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler)
 Time elapsed: 0.079 sec  <<< FAILURE!
java.lang.AssertionError: expected:<null> but was:<pid=2, state=RUNNABLE; TestTableProcedure(table=ns1:testVerifyNamespaceXLock)>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler.testVerifyNamespaceXLock(TestMasterProcedureScheduler.java:329)

testVerifyNamespaceRwLocks(org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler)
 Time elapsed: 0.08 sec  <<< FAILURE!
java.lang.AssertionError: expected:<3> but was:<2>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:645)
	at org.junit.Assert.assertEquals(Assert.java:631)
	at org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler.testVerifyNamespaceRwLocks(TestMasterProcedureScheduler.java:291)

testVerifyNamespaceRwLocks(org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler)
 Time elapsed: 0.08 sec  <<< FAILURE!
java.lang.AssertionError: proc-queue expected to be empty expected:<0> but was:<2>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:645)
	at org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler.tearDown(TestMasterProcedureScheduler.java:69)


Results :

Failed tests:
org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler.testVerifyNamespaceRwLocks(org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler)
  Run 1: TestMasterProcedureScheduler.testVerifyNamespaceRwLocks:291 expected:<3> but
was:<2>
  Run 2: TestMasterProcedureScheduler.tearDown:69 proc-queue expected to be empty expected:<0>
but was:<2>

  TestMasterProcedureScheduler.testVerifyNamespaceXLock:329 expected:<null> but was:<pid=2,
state=RUNNABLE; TestTableProcedure(table=ns1:testVerifyNamespaceXLock)>

Tests run: 22, Failures: 2, Errors: 0, Skipped: 0
{code}

> Remove Queue#isAvailable() since we have waits/wakes after HBASE-17067
> ----------------------------------------------------------------------
>
>                 Key: HBASE-17537
>                 URL: https://issues.apache.org/jira/browse/HBASE-17537
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master, proc-v2
>            Reporter: Appy
>            Assignee: Appy
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17537.master.001.patch, HBASE-17537.master.002.patch
>
>
> Earlier, run-queues could have empty queues or queues for which exclusive locks are already
taken. Thus poll() on table/server run-queue might have returned a Queue which didn't have
any valid procs to run.
> With wait/wake on exclusive locks doing {removeFrom|addTo}RunQueue and poll removing
queues when last element is removed, i think we can remove this function now.
> (am finding these things when working on a larger patch, but there are changes like this
which seem too critical to mess up, so am creating smaller focused patches for them).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message