hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
Date Thu, 29 Jun 2017 03:10:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067636#comment-16067636

stack commented on HBASE-14135:

Why is this backup stuff in hbase-server? BackupAdmin, BackupMergeJob, etc. and not in hbase-backup?
This is phase 3. I'd have thought the backup module would be well along by now (Where do I
go to read on current state of backup feature?) hbase-server is already overly fat with test
suite that takes way too long, etc., etc. Lets not compound.

BackupMergeJob is a MR job or something?  I presume that is what the 'Job' is about? There
is nothing in class comment saying so.. .just generic Interface. Drop the 'Job' on classname
if Interface has no requirement that implementation be a MR job (could it be done w/ Spark
or in a simple process?)

Why does the formatting in this patch differ from that of the rest of the code? (line between
class comment or method comment and class opener or method...  parens on own lines instead
of at end of method spec line... Sometimes operators/parens have spaces around or before them,
other times they do not...

mergeBackups doesn't return a future? It is synchronous? Doc says nothing on this.

> HBase Backup/Restore Phase 3: Merge backup images
> -------------------------------------------------
>                 Key: HBASE-14135
>                 URL: https://issues.apache.org/jira/browse/HBASE-14135
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>            Priority: Blocker
>              Labels: backup
>             Fix For: HBASE-7912
>         Attachments: HBASE-14135-v1.patch, HBASE-14135-v3.patch
> User can merge incremental backup images into single incremental backup image.
> # Merge supports only incremental images
> # Merge supports only images for the same backup destinations
> Command:
> {code}
> hbase backup merge image1,image2,..imageK
> {code}
> Example:
> {code}
> hbase backup merge backup_143126764557,backup_143126764456 
> {code}
> When operation is complete, only the most recent backup image will be kept (in above
example -  backup_143126764557) as a merged backup image, all other images will be deleted
from both: file system and backup system tables, corresponding backup manifest for the merged
backup image will be updated to remove dependencies from deleted images. Merged backup image
will contains all the data from original image and from deleted images.

This message was sent by Atlassian JIRA

View raw message