Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9FAF3200CA7 for ; Tue, 30 May 2017 20:15:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9E545160BB1; Tue, 30 May 2017 18:15:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C8BF2160BC9 for ; Tue, 30 May 2017 20:15:09 +0200 (CEST) Received: (qmail 73017 invoked by uid 500); 30 May 2017 18:15:09 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 72993 invoked by uid 99); 30 May 2017 18:15:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 May 2017 18:15:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 6E9EDC0620 for ; Tue, 30 May 2017 18:15:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 7ssXMmB5bH1H for ; Tue, 30 May 2017 18:15:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 495DD5FD8E for ; Tue, 30 May 2017 18:15:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9C39EE0D54 for ; Tue, 30 May 2017 18:15:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 16AAF21B5C for ; Tue, 30 May 2017 18:15:05 +0000 (UTC) Date: Tue, 30 May 2017 18:15:05 +0000 (UTC) From: "Enis Soztutar (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18097) Client can save 1 RPC call for CloseScannerRequest MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 30 May 2017 18:15:10 -0000 [ https://issues.apache.org/jira/browse/HBASE-18097?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D160= 29861#comment-16029861 ]=20 Enis Soztutar commented on HBASE-18097: --------------------------------------- bq. The first part for saving 1 RPC request is already implemented as a par= t of HBASE-17508, where the scannerId is set to -1 whenever results are not= left in region.=20 Maybe change the title to focus on the second part then.=20 Protobuf repeated fields in proto-2 encoding will not use extra bytes for t= he array representation (unless packed=3Dtrue). However, you are right that= , for every row in the ScanResponse object, we are setting a bool in the re= peated field like this:=20 {code} 2017-05-23 18:06:42,133 TRACE [B.fifo.QRpcServer.handler=3D9,queue=3D1,port= =3D16020] ipc.RpcServer: callId: 384494 service: ClientService methodName: = Scan size: 33 connection: param: scanner_id: 12244464 number_of_r= ows: 100 close_scanner: false next_call_seq: 384492 client_handles_partials= : true client_handles_heartbeats: true renew: false connection: , = response cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_= per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 c= ells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result= : 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_r= esult: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_= per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 c= ells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result= : 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_r= esult: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_= per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 c= ells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result= : 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_r= esult: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_= per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 c= ells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result= : 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_r= esult: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_= per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 c= ells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result= : 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_r= esult: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_= per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 c= ells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result= : 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_r= esult: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_= per_result: 5 cells_per_result: 5 cells_per_result: 5 cells_per_result: 5 c= ells_per_result: 5 cells_per_result: 5 cells_per_result: 5 scanner_id: 1224= 4464 more_results: true ttl: 60000 stale: false partial_flag_per_result: fa= lse partial_flag_per_result: false partial_flag_per_result: false partial_f= lag_per_result: false partial_flag_per_result: false partial_flag_per_resul= t: false partial_flag_per_result: false partial_flag_per_result: false part= ial_flag_per_result: false partial_flag_per_result: false partial_flag_per_= result: false partial_flag_per_result: false partial_flag_per_result: false= partial_flag_per_result: false partial_flag_per_result: false partial_flag= _per_result: false partial_flag_per_result: false partial_flag_per_result: = false partial_flag_per_result: false partial_flag_per_result: false partial= _flag_per_result: false partial_flag_per_result: false partial_flag_per_res= ult: false partial_flag_per_result: false partial_flag_per_result: false pa= rtial_flag_per_result: false partial_flag_per_result: false partial_flag_pe= r_result: false partial_flag_per_result: false partial_flag_per_result: fal= se partial_flag_per_result: false partial_flag_per_result: false partial_fl= ag_per_result: false partial_flag_per_result: false partial_flag_per_result= : false partial_flag_per_result: false partial_flag_per_result: false parti= al_flag_per_result: false partial_flag_per_result: false partial_flag_per_r= esult: false partial_flag_per_result: false partial_flag_per_result: false = partial_flag_per_result: false partial_flag_per_result: false partial_flag_= per_result: false partial_flag_per_result: false partial_flag_per_result: f= alse partial_flag_per_result: false partial_flag_per_result: false partial_= flag_per_result: false partial_flag_per_result: false partial_flag_per_resu= lt: false partial_flag_per_result: false partial_flag_per_result: false par= tial_flag_per_result: false partial_flag_per_result: false partial_flag_per= _result: false partial_flag_per_result: false partial_flag_per_result: fals= e partial_flag_per_result: false partial_flag_per_result: false partial_fla= g_per_result: false partial_flag_per_result: false partial_flag_per_result:= false partial_flag_per_result: false partial_flag_per_result: false partia= l_flag_per_result: false partial_flag_per_result: false partial_flag_per_re= sult: false partial_flag_per_result: false partial_flag_per_result: false p= artial_flag_per_result: false partial_flag_per_result: false partial_flag_p= er_result: false partial_flag_per_result: false partial_flag_per_result: fa= lse partial_flag_per_result: false partial_flag_per_result: false partial_f= lag_per_result: false partial_flag_per_result: false partial_flag_per_resul= t: false partial_flag_per_result: false partial_flag_per_result: false part= ial_flag_per_result: false partial_flag_per_result: false partial_flag_per_= result: false partial_flag_per_result: false partial_flag_per_result: false= partial_flag_per_result: false partial_flag_per_result: false partial_flag= _per_result: false partial_flag_per_result: false partial_flag_per_result: = false partial_flag_per_result: false partial_flag_per_result: false partial= _flag_per_result: false partial_flag_per_result: false partial_flag_per_res= ult: false partial_flag_per_result: false partial_flag_per_result: false mo= re_results_in_region: true heartbeat_message: false queueTime: 0 processing= Time: 1 totalTime: 1 {code} The array of {{partial_flag_per_result}} is a waste of bandwidth space.=20 > Client can save 1 RPC call for CloseScannerRequest > -------------------------------------------------- > > Key: HBASE-18097 > URL: https://issues.apache.org/jira/browse/HBASE-18097 > Project: HBase > Issue Type: Improvement > Reporter: Karan Mehta > > Starting version 1.3, HBase automatically closes scanner on server side w= henever the results are exhausted and corresponding bits are set in the {{S= canResponse}} proto returned to the client. We can use that info to elimina= te the closeScanRequest RPC call, thereby saving 1 RPC per region per scan.= This can be particularly useful for tables with more regions. > Also, currently the {{ScanResponse}} proto sends out 1 bit per {{Result}}= that it has embeds inside the {{CellScanner}} to indicate if it is partial= or not.=20 > {code} > // In every RPC response there should be at most a single partial res= ult. Furthermore, if > // there is a partial result, it is guaranteed to be in the last posi= tion of the array. > {code} > According to client, only the last result can be partial, thus this repea= ted bool can be converted to a bool, thus reducing overhead of serializatio= n and deserialization of the array. This will break wire compatibility ther= efore this is something to look for in upcoming versions. -- This message was sent by Atlassian JIRA (v6.3.15#6346)