Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E0717200C89 for ; Sat, 20 May 2017 02:20:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id DEF6E160BD1; Sat, 20 May 2017 00:20:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0A9B5160BD2 for ; Sat, 20 May 2017 02:20:08 +0200 (CEST) Received: (qmail 12863 invoked by uid 500); 20 May 2017 00:20:08 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 12852 invoked by uid 99); 20 May 2017 00:20:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 20 May 2017 00:20:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id BBA0F1A0486 for ; Sat, 20 May 2017 00:20:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id o2-YvQBv6mWf for ; Sat, 20 May 2017 00:20:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A3E3E5FB40 for ; Sat, 20 May 2017 00:20:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BEF9EE07E1 for ; Sat, 20 May 2017 00:20:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1E5FB21B58 for ; Sat, 20 May 2017 00:20:04 +0000 (UTC) Date: Sat, 20 May 2017 00:20:04 +0000 (UTC) From: "Appy (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18068) Fix flaky test TestAsyncSnapshotAdminApi MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 20 May 2017 00:20:10 -0000 [ https://issues.apache.org/jira/browse/HBASE-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018198#comment-16018198 ] Appy commented on HBASE-18068: ------------------------------ [~zheng hu] uploaded patch. Real bug fix is just 10 lines, rest is landscaping. [ReviewBoard|https://reviews.apache.org/r/59425/] > Fix flaky test TestAsyncSnapshotAdminApi > ---------------------------------------- > > Key: HBASE-18068 > URL: https://issues.apache.org/jira/browse/HBASE-18068 > Project: HBase > Issue Type: Sub-task > Components: Client > Reporter: Appy > Assignee: Appy > Fix For: 2.0.0 > > Attachments: HBASE-18068.master.001.patch > > > Test failures > {noformat} > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testRestoreSnapshot > -------------------------------------------------------------------------------- > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: Restore already in progress on the table=testRestoreSnapshot > at org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:854) > at org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:818) > at org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreOrCloneSnapshot(SnapshotManager.java:780) > at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2324) > at org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:133) > at org.apache.hadoop.hbase.master.HMaster.restoreSnapshot(HMaster.java:2320) > at org.apache.hadoop.hbase.master.MasterRpcServices.restoreSnapshot(MasterRpcServices.java:1224) > at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > -------------------------------------------------------------------------------- > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testDeleteSnapshots > -------------------------------------------------------------------------------- > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: org.apache.hadoop.hbase.snapshot.SnapshotCreationException: Rejected taking { ss=snapshotName1 table=testDeleteSnapshots type=FLUSH } because we are already running another snapshot on the same table { ss=snapshotName1 table=testDeleteSnapshots type=FLUSH } > at org.apache.hadoop.hbase.master.snapshot.SnapshotManager.prepareToTakeSnapshot(SnapshotManager.java:440) > at org.apache.hadoop.hbase.master.snapshot.SnapshotManager.snapshotEnabledTable(SnapshotManager.java:497) > at org.apache.hadoop.hbase.master.snapshot.SnapshotManager.takeSnapshot(SnapshotManager.java:598) > at org.apache.hadoop.hbase.master.MasterRpcServices.snapshot(MasterRpcServices.java:1299) > at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > -------------------------------------------------------------------------------- > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testListSnapshots > -------------------------------------------------------------------------------- > org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException: Snapshot 'snapshotName2' doesn't exist on the filesystem > at org.apache.hadoop.hbase.master.snapshot.SnapshotManager.deleteSnapshot(SnapshotManager.java:289) > at org.apache.hadoop.hbase.master.MasterRpcServices.deleteSnapshot(MasterRpcServices.java:461) > at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > -------------------------------------------------------------------------------- > {noformat} > https://builds.apache.org/job/HBASE-Flaky-Tests/16152/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)