Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F12C1200C7E for ; Tue, 23 May 2017 10:22:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EFA71160BC3; Tue, 23 May 2017 08:22:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C039C160BB6 for ; Tue, 23 May 2017 10:22:10 +0200 (CEST) Received: (qmail 52637 invoked by uid 500); 23 May 2017 08:22:09 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 52625 invoked by uid 99); 23 May 2017 08:22:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 May 2017 08:22:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 772D9C05CB for ; Tue, 23 May 2017 08:22:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.201 X-Spam-Level: X-Spam-Status: No, score=-99.201 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 8zdMolMzJIkD for ; Tue, 23 May 2017 08:22:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B22F85FD7D for ; Tue, 23 May 2017 08:22:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0D6F1E0D77 for ; Tue, 23 May 2017 08:22:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7FEFE21B5C for ; Tue, 23 May 2017 08:22:04 +0000 (UTC) Date: Tue, 23 May 2017 08:22:04 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18060) Backport to branch-1 HBASE-9774 HBase native metrics and metric collection for coprocessors MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 23 May 2017 08:22:12 -0000 [ https://issues.apache.org/jira/browse/HBASE-18060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020791#comment-16020791 ] Hadoop QA commented on HBASE-18060: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 32s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 14 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 25s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 31s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 42s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 7m 25s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 4m 26s {color} | {color:green} branch-1 passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue} Skipped patched modules with no Java source: hbase-assembly hbase-assembly . {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 3s {color} | {color:red} hbase-common in branch-1 has 1 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 4s {color} | {color:red} hbase-common in branch-1 has 1 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 34s {color} | {color:red} hbase-hadoop2-compat in branch-1 has 1 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 40s {color} | {color:red} hbase-hadoop2-compat in branch-1 has 1 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 52s {color} | {color:red} hbase-server in branch-1 has 1 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 50s {color} | {color:red} hbase-server in branch-1 has 1 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m 51s {color} | {color:green} branch-1 passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 3m 24s {color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 20s {color} | {color:red} hbase-assembly in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 2m 23s {color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 19s {color} | {color:red} hbase-assembly in the patch failed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 26s {color} | {color:red} hbase-common generated 8 new + 10 unchanged - 10 fixed = 18 total (was 20) {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 14s {color} | {color:green} hbase-metrics-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 15s {color} | {color:green} hbase-hadoop-compat in the patch passed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 23s {color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 19s {color} | {color:red} hbase-assembly in the patch failed. {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 21s {color} | {color:green} hbase-examples in the patch passed. {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 16s {color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 16s {color} | {color:green} hbase-metrics in the patch passed. {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 9s {color} | {color:green} hbase-server generated 0 new + 5 unchanged - 5 fixed = 5 total (was 10) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 6m 18s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} mvneclipse {color} | {color:red} 1m 5s {color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} mvneclipse {color} | {color:red} 0m 25s {color} | {color:red} hbase-assembly in the patch failed. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 21s {color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m 23s {color} | {color:red} The patch causes 11 errors with Hadoop v2.4.0. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m 27s {color} | {color:red} The patch causes 11 errors with Hadoop v2.4.1. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 9m 33s {color} | {color:red} The patch causes 11 errors with Hadoop v2.5.0. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 12m 47s {color} | {color:red} The patch causes 11 errors with Hadoop v2.5.1. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 15m 56s {color} | {color:red} The patch causes 11 errors with Hadoop v2.5.2. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 18m 59s {color} | {color:red} The patch causes 11 errors with Hadoop v2.6.1. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 22m 3s {color} | {color:red} The patch causes 11 errors with Hadoop v2.6.2. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 25m 19s {color} | {color:red} The patch causes 11 errors with Hadoop v2.6.3. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 28m 36s {color} | {color:red} The patch causes 11 errors with Hadoop v2.7.1. {color} | | {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 1m 37s {color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 28s {color} | {color:red} hbase-assembly in the patch failed. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue} Skipped patched modules with no Java source: . hbase-assembly {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 11m 44s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 37s {color} | {color:green} hbase-common generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s {color} | {color:green} hbase-metrics-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 23s {color} | {color:green} hbase-hadoop-compat in the patch passed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 29s {color} | {color:green} root in the patch passed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s {color} | {color:green} hbase-assembly in the patch passed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 23s {color} | {color:green} hbase-examples in the patch passed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s {color} | {color:green} hbase-hadoop2-compat generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s {color} | {color:green} hbase-metrics in the patch passed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 0s {color} | {color:green} hbase-server generated 0 new + 3 unchanged - 3 fixed = 3 total (was 6) {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 21s {color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 21s {color} | {color:green} hbase-metrics-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 35s {color} | {color:green} hbase-hadoop-compat in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 195m 15s {color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 26s {color} | {color:red} hbase-assembly in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 34s {color} | {color:green} hbase-examples in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 42s {color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 29s {color} | {color:green} hbase-metrics in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 142m 7s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m 42s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 472m 44s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 | | | hadoop.hbase.regionserver.TestCompactionInDeadRegionServer | | | hadoop.hbase.master.TestMasterMetrics | | | hadoop.hbase.regionserver.TestSplitTransactionOnCluster | | | hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 | | | hadoop.hbase.regionserver.TestCompactionInDeadRegionServer | | | hadoop.hbase.master.TestMasterMetrics | | | hadoop.hbase.regionserver.TestSplitTransactionOnCluster | | Timed out junit tests | org.apache.hadoop.hbase.replication.regionserver.TestReplicationWALReaderManager | | | org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:58c504e | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12869374/HBASE-18060.branch-1.v5.patch | | JIRA Issue | HBASE-18060 | | Optional Tests | asflicense javac javadoc unit xml compile findbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 518eefdee8d7 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/hbase.sh | | git revision | branch-1 / 4249a1f | | Default Java | 1.8.0_131 | | findbugs | v3.0.0 | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/branch-findbugs-hbase-common-warnings.html | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/branch-findbugs-hbase-common-warnings.html | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/branch-findbugs-hbase-hadoop2-compat-warnings.html | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/branch-findbugs-hbase-hadoop2-compat-warnings.html | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html | | mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/patch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/patch-mvninstall-hbase-assembly.txt | | compile | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/patch-compile-root.txt | | compile | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/patch-compile-hbase-assembly.txt | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/diff-compile-javac-hbase-common.txt | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/patch-compile-root.txt | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/patch-compile-hbase-assembly.txt | | mvneclipse | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/patch-mvneclipse-root.txt | | mvneclipse | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/patch-mvneclipse-hbase-assembly.txt | | hbaseprotoc | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/patch-hbaseprotoc-root.txt | | hbaseprotoc | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/patch-hbaseprotoc-hbase-assembly.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/patch-unit-root.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/patch-unit-hbase-assembly.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/patch-unit-hbase-server.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/patch-unit-root.txt https://builds.apache.org/job/PreCommit-HBASE-Build/6887/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/testReport/ | | modules | C: hbase-common hbase-metrics-api hbase-hadoop-compat . hbase-assembly hbase-examples hbase-hadoop2-compat hbase-metrics hbase-server U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/6887/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Backport to branch-1 HBASE-9774 HBase native metrics and metric collection for coprocessors > ------------------------------------------------------------------------------------------- > > Key: HBASE-18060 > URL: https://issues.apache.org/jira/browse/HBASE-18060 > Project: HBase > Issue Type: New Feature > Affects Versions: 1.4.0, 1.3.2, 1.5.0 > Reporter: Vincent Poon > Assignee: Vincent Poon > Attachments: HBASE-18060.branch-1.3.v1.patch, HBASE-18060.branch-1.3.v2.patch, HBASE-18060.branch-1.3.v3.patch, HBASE-18060.branch-1.3.v4.patch, HBASE-18060.branch-1.3.v5.patch, HBASE-18060.branch-1.v1.patch, HBASE-18060.branch-1.v2.patch, HBASE-18060.branch-1.v3.patch, HBASE-18060.branch-1.v4.patch, HBASE-18060.branch-1.v5.patch > > > I'd like to explore backporting HBASE-9774 to branch-1, as the ability for coprocessors to report custom metrics through HBase is useful for us, and if we have coprocessors use the native API, a re-write won't be necessary after an upgrade to 2.0. > The main issues I see so far are: > - the usage of Java 8 language features. Seems we can work around this as most of it is syntactic sugar. Will need to find a backport for LongAdder > - dropwizard 3.1.2 in Master. branch-1 is still on yammer metrics 2.2. Not sure if these can coexist just for this feature -- This message was sent by Atlassian JIRA (v6.3.15#6346)