Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 08354200C86 for ; Wed, 17 May 2017 00:36:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 06E3E160BC9; Tue, 16 May 2017 22:36:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 54D68160BC1 for ; Wed, 17 May 2017 00:36:11 +0200 (CEST) Received: (qmail 16565 invoked by uid 500); 16 May 2017 22:36:10 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 16554 invoked by uid 99); 16 May 2017 22:36:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 May 2017 22:36:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 200671A027F for ; Tue, 16 May 2017 22:36:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 5fNS2WodjXed for ; Tue, 16 May 2017 22:36:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 31DFD5FBC1 for ; Tue, 16 May 2017 22:36:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 951AEE06C2 for ; Tue, 16 May 2017 22:36:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 152F92193E for ; Tue, 16 May 2017 22:36:04 +0000 (UTC) Date: Tue, 16 May 2017 22:36:04 +0000 (UTC) From: "Enis Soztutar (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18060) Backport to branch-1 HBASE-9774 HBase native metrics and metric collection for coprocessors MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 16 May 2017 22:36:12 -0000 [ https://issues.apache.org/jira/browse/HBASE-18060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013213#comment-16013213 ] Enis Soztutar commented on HBASE-18060: --------------------------------------- I think you have identified the main issues nicely. Some of the new APIs are using JDK-8 features that have to be rethought of. Some un-sugaring is needed. Most of the changes are in the new modules, so I won't be too much concerned about them. The harder parts to backport would be at the DW -> hadoop metrics2 integration layer I think. However, if we do this backport, it will make it easier for further patches that uses the new framework to be backported. > Backport to branch-1 HBASE-9774 HBase native metrics and metric collection for coprocessors > ------------------------------------------------------------------------------------------- > > Key: HBASE-18060 > URL: https://issues.apache.org/jira/browse/HBASE-18060 > Project: HBase > Issue Type: New Feature > Affects Versions: 1.4.0, 1.3.2, 1.5.0 > Reporter: Vincent Poon > Assignee: Vincent Poon > > I'd like to explore backporting HBASE-9774 to branch-1, as the ability for coprocessors to report custom metrics through HBase is useful for us, and if we have coprocessors use the native API, a re-write won't be necessary after an upgrade to 2.0. > The main issues I see so far are: > - the usage of Java 8 language features. Seems we can work around this as most of it is syntactic sugar. Will need to find a backport for LongAdder > - dropwizard 3.1.2 in Master. branch-1 is still on yammer metrics 2.2. Not sure if these can coexist just for this feature -- This message was sent by Atlassian JIRA (v6.3.15#6346)