Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 43EE1200C67 for ; Mon, 15 May 2017 18:56:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 426AC160BC2; Mon, 15 May 2017 16:56:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8EBC3160BCE for ; Mon, 15 May 2017 18:56:09 +0200 (CEST) Received: (qmail 26234 invoked by uid 500); 15 May 2017 16:56:08 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 26222 invoked by uid 99); 15 May 2017 16:56:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 May 2017 16:56:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 503C1CF987 for ; Mon, 15 May 2017 16:56:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id eesYD-8ttQ5G for ; Mon, 15 May 2017 16:56:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 34F565FC1C for ; Mon, 15 May 2017 16:56:07 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 877A3E0D69 for ; Mon, 15 May 2017 16:56:06 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 70D062436C for ; Mon, 15 May 2017 16:56:05 +0000 (UTC) Date: Mon, 15 May 2017 16:56:05 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18051) balance_rsgroup still run when the Load Balancer is not enabled. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 15 May 2017 16:56:10 -0000 [ https://issues.apache.org/jira/browse/HBASE-18051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010900#comment-16010900 ] Ted Yu commented on HBASE-18051: -------------------------------- HBaseAdmin has the following method: {code} public boolean isBalancerEnabled() throws IOException { {code} MasterRpcServices has: {code} public IsBalancerEnabledResponse isBalancerEnabled(RpcController controller, IsBalancerEnabledRequest request) throws ServiceException { IsBalancerEnabledResponse.Builder response = IsBalancerEnabledResponse.newBuilder(); response.setEnabled(master.isBalancerOn()); {code} See if you can utilize existing method(s) and not add isBalancerOn() to MasterServices > balance_rsgroup still run when the Load Balancer is not enabled. > ---------------------------------------------------------------- > > Key: HBASE-18051 > URL: https://issues.apache.org/jira/browse/HBASE-18051 > Project: HBase > Issue Type: Bug > Components: rsgroup > Affects Versions: 2.0.0 > Reporter: Guangxu Cheng > Assignee: Guangxu Cheng > Fix For: 2.0.0 > > Attachments: HBASE-18051-v1.patch > > > When the Load Balancer is not enabled, the command "balancer" will not be executed , but the command "balance_rsgroup" can still run, which is not reasonable.So we need to fix it -- This message was sent by Atlassian JIRA (v6.3.15#6346)