Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C947D200CA9 for ; Fri, 12 May 2017 00:30:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C7E9D160BC7; Thu, 11 May 2017 22:30:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1F10F160BCA for ; Fri, 12 May 2017 00:30:09 +0200 (CEST) Received: (qmail 17796 invoked by uid 500); 11 May 2017 22:30:09 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 17749 invoked by uid 99); 11 May 2017 22:30:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 May 2017 22:30:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id CB1171AFAFF for ; Thu, 11 May 2017 22:30:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id bXobWHAh49-c for ; Thu, 11 May 2017 22:30:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5DCD360ED2 for ; Thu, 11 May 2017 22:30:07 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5C1A1E0D22 for ; Thu, 11 May 2017 22:30:06 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id E56AD21E11 for ; Thu, 11 May 2017 22:30:04 +0000 (UTC) Date: Thu, 11 May 2017 22:30:04 +0000 (UTC) From: "Dima Spivak (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18020) Update API Compliance Checker to Incorporate Improvements Done in Hadoop MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 11 May 2017 22:30:11 -0000 [ https://issues.apache.org/jira/browse/HBASE-18020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007307#comment-16007307 ] Dima Spivak commented on HBASE-18020: ------------------------------------- I guess what I'm saying is that the effort to convert this patch from Python 2 to Python 3 will be minimal, but by doing so, you'll be able to make certain assumptions that will aid significantly in readability. For example, {{argparse}} is part of the Python 3 standard library, so there'd be no need to worry about not being able to import it. Furthermore, using {{os.path}} is gross and awful and exactly why Python 3 has {{pathlib}}. Just my two cents. > Update API Compliance Checker to Incorporate Improvements Done in Hadoop > ------------------------------------------------------------------------ > > Key: HBASE-18020 > URL: https://issues.apache.org/jira/browse/HBASE-18020 > Project: HBase > Issue Type: Improvement > Components: API, community > Reporter: Alex Leblang > Assignee: Alex Leblang > Fix For: 2.0.0 > > Attachments: HBASE-18020.0.patch > > > Recently the Hadoop community has made a number of improvements in their api compliance checker based on feedback from the hbase and kudu community. We should adopt these changes ourselves. -- This message was sent by Atlassian JIRA (v6.3.15#6346)