Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 17 May 2017 05:46:04 +0000 (UTC)
From: "Duo Zhang (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13070553.1494357284000.227881.1494999964108@Atlassian.JIRA>
In-Reply-To: <JIRA.13070553.1494357284000@Atlassian.JIRA>
References: <JIRA.13070553.1494357284000@Atlassian.JIRA> <JIRA.13070553.1494357284976@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-18019) Clear redundant memstore scanners
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 17 May 2017 05:46:08 -0000


    [ https://issues.apache.org/jira/browse/HBASE-18019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013562#comment-16013562 ] 

Duo Zhang commented on HBASE-18019:
-----------------------------------

{quote}
We will be creating new memstore scanner (after the flush) and that is been added. Ideally only the snapshot scanner should get cleared but to do that we will need larger change. We discussed abt this in 17887
{quote}

Got it. No question then. +1.

> Clear redundant memstore scanners
> ---------------------------------
>
>                 Key: HBASE-18019
>                 URL: https://issues.apache.org/jira/browse/HBASE-18019
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>             Fix For: 2.0.0
>
>         Attachments: HBASE-18019.v0.patch
>
>
> The HBASE-17655 remove the MemStoreScanner and it causes that the MemStore#getScanner(readpt) returns multi KeyValueScanner which consist of active, snapshot and pipeline. But StoreScanner only remove one mem scanner when refreshing current scanners.
> {code}
>     for (int i = 0; i < currentScanners.size(); i++) {
>       if (!currentScanners.get(i).isFileScanner()) {
>         currentScanners.remove(i);
>         break;
>       }
>     }
> {code}
> The older scanners kept in the StoreScanner will hinder GC from releasing memory and lead to multiple scans on the same data.
>  


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)