Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DFD74200C86 for ; Wed, 17 May 2017 07:00:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id DE674160BC1; Wed, 17 May 2017 05:00:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2EFEB160BC9 for ; Wed, 17 May 2017 07:00:15 +0200 (CEST) Received: (qmail 36950 invoked by uid 500); 17 May 2017 05:00:14 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 36844 invoked by uid 99); 17 May 2017 05:00:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 May 2017 05:00:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 859EDC194C for ; Wed, 17 May 2017 05:00:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Ppi0NmYg67IN for ; Wed, 17 May 2017 05:00:12 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 533455FD6D for ; Wed, 17 May 2017 05:00:12 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BD214E06C2 for ; Wed, 17 May 2017 05:00:11 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 00838263B2 for ; Wed, 17 May 2017 05:00:11 +0000 (UTC) Date: Wed, 17 May 2017 05:00:11 +0000 (UTC) From: "Chia-Ping Tsai (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18019) Clear redundant memstore scanners MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 17 May 2017 05:00:16 -0000 [ https://issues.apache.org/jira/browse/HBASE-18019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013527#comment-16013527 ] Chia-Ping Tsai commented on HBASE-18019: ---------------------------------------- bq. If the store is being flushed when we create the scanner, then after flush the snapshot is gone but we still need to scan the memstore? The new hfiles is added before the snapshot is gone, so we can get data from the new hfiles even if the snapshot is gone. > Clear redundant memstore scanners > --------------------------------- > > Key: HBASE-18019 > URL: https://issues.apache.org/jira/browse/HBASE-18019 > Project: HBase > Issue Type: Improvement > Affects Versions: 2.0.0 > Reporter: Chia-Ping Tsai > Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-18019.v0.patch > > > The HBASE-17655 remove the MemStoreScanner and it causes that the MemStore#getScanner(readpt) returns multi KeyValueScanner which consist of active, snapshot and pipeline. But StoreScanner only remove one mem scanner when refreshing current scanners. > {code} > for (int i = 0; i < currentScanners.size(); i++) { > if (!currentScanners.get(i).isFileScanner()) { > currentScanners.remove(i); > break; > } > } > {code} > The older scanners kept in the StoreScanner will hinder GC from releasing memory and lead to multiple scans on the same data. > -- This message was sent by Atlassian JIRA (v6.3.15#6346)