Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B5283200C8E for ; Wed, 24 May 2017 16:38:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B402F160B9C; Wed, 24 May 2017 14:38:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 03074160BB4 for ; Wed, 24 May 2017 16:38:10 +0200 (CEST) Received: (qmail 22614 invoked by uid 500); 24 May 2017 14:38:08 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 22594 invoked by uid 99); 24 May 2017 14:38:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 May 2017 14:38:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 51B2F180313 for ; Wed, 24 May 2017 14:38:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id wiHHLborH_v2 for ; Wed, 24 May 2017 14:38:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B37125F3FE for ; Wed, 24 May 2017 14:38:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 028E7E0D4D for ; Wed, 24 May 2017 14:38:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5A72621B5A for ; Wed, 24 May 2017 14:38:04 +0000 (UTC) Date: Wed, 24 May 2017 14:38:04 +0000 (UTC) From: "Zheng Hu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References:

Subject: [jira] [Commented] (HBASE-18006) AsyncClientScanner does not retry openScan RPCs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 24 May 2017 14:38:11 -0000 [ https://issues.apache.org/jira/browse/HBASE-18006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022981#comment-16022981 ] Zheng Hu commented on HBASE-18006: ---------------------------------- The javadoc said that: {code} /** * Move the region r to dest. * * @param encodedRegionName The encoded region name; i.e. the hash that makes up the region name * suffix: e.g. if regionname is * TestTable,0094429456,1289497600452.527db22f95c8a9e0116f0cc13c680396., * then the encoded region name is: 527db22f95c8a9e0116f0cc13c680396. * @param destServerName The servername of the destination regionserver. If passed the empty byte * array we'll assign to a random server. A server name is made of host, port and startcode. * Here is an example: host187.example.com,60020,1289493121758 * @throws IOException if we can't find a region named * encodedRegionName */ void move(final byte[] encodedRegionName, final byte[] destServerName) throws IOException; {code} So , we can only pass a encodedRegionName to HBaseAdmin.move() method. In our HBaseAdmin , some API accept encodedRegionName only , some API need fullRegionName only , some API accept both encodedRegionName and fulRegionName , It really confused me sometime. :( Anyway, it's not a bug, so I closed the issue. > AsyncClientScanner does not retry openScan RPCs > ----------------------------------------------- > > Key: HBASE-18006 > URL: https://issues.apache.org/jira/browse/HBASE-18006 > Project: HBase > Issue Type: Bug > Reporter: Enis Soztutar > Priority: Critical > Fix For: 2.0.0 > > Attachments: hbase-18006-test.patch > > > I have been reading the code for the new async scan paths excessively, and noticed that there is a problem in the retrying layer for openScan RPCs. > In AsyncClientScanner#callOpenScanner() we are doing a open scan RPC. The retrying logic comes from using the single rpc retrying caller in openScanner(). However, we have the logic for failing the scanner if any of the RPC calls here: > {code} > stub.scan(controller, request, resp -> { > if (controller.failed()) { > future.completeExceptionally(controller.getFailed()); > return; > } > future.complete(new OpenScannerResponse(loc, isRegionServerRemote, stub, controller, resp)); > }); > {code} > So, if the open scan gets an UnknownScannerException or something, instead of retrying, it just fails the whole scan. > [~Apache9] FYI. -- This message was sent by Atlassian JIRA (v6.3.15#6346)