Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B7ADA200C70 for ; Thu, 4 May 2017 10:58:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B640A160BB0; Thu, 4 May 2017 08:58:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 09568160B9F for ; Thu, 4 May 2017 10:58:06 +0200 (CEST) Received: (qmail 53136 invoked by uid 500); 4 May 2017 08:58:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 53125 invoked by uid 99); 4 May 2017 08:58:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 May 2017 08:58:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C8FBA1A0905 for ; Thu, 4 May 2017 08:58:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id PO2uccT3HsR4 for ; Thu, 4 May 2017 08:58:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CF50B5F1BA for ; Thu, 4 May 2017 08:58:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 63A8DE0234 for ; Thu, 4 May 2017 08:58:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1D90221DEA for ; Thu, 4 May 2017 08:58:04 +0000 (UTC) Date: Thu, 4 May 2017 08:58:04 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17992) The snapShot TimeoutException causes the cleanerChore thread to fail to complete the archive correctly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 04 May 2017 08:58:07 -0000 [ https://issues.apache.org/jira/browse/HBASE-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996388#comment-15996388 ] Ted Yu commented on HBASE-17992: -------------------------------- Can you cover enabledTableSnapshot as well ? > The snapShot TimeoutException causes the cleanerChore thread to fail to complete the archive correctly > ------------------------------------------------------------------------------------------------------ > > Key: HBASE-17992 > URL: https://issues.apache.org/jira/browse/HBASE-17992 > Project: HBase > Issue Type: Bug > Components: snapshots > Affects Versions: 0.98.10, 1.3.0 > Reporter: Bo Cui > > The problem is that when the snapshot occurs TimeoutException or other Exceptions, there is no correct delete /hbase/.hbase-snapshot/tmp, which causes the cleanerChore to fail to complete the archive correctly. > Modifying the configuration parameter (hbase.snapshot.master.timeout.millis = 600000) only reduces the probability of the problem occurring. > So the solution to the problem is: multi-Threaded exceptions or TimeoutExceptions, the Main-thread must wait until all the tasks are finished or canceled, the Main-thread can be cleared /hbase/.hbase-snapshot/tmp/snapshotName.Otherwise the task is likely to write /hbase/.hbase-snapshot/tmp/snapshotName/region - mainfest > The problem exists in disabledTableSnapshot and enabledTableSnapshot, because I'm currently using the disabledTableSnapshot, so I provide the patch of disabledTableSnapshot -- This message was sent by Atlassian JIRA (v6.3.15#6346)