Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 9 May 2017 03:03:04 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13064133.1492197195000.159631.1494298984184@Atlassian.JIRA>
In-Reply-To: <JIRA.13064133.1492197195000@Atlassian.JIRA>
References: <JIRA.13064133.1492197195000@Atlassian.JIRA> <JIRA.13064133.1492197195835@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-17924) Consider sorting the row order
 when processing multi() ops before taking rowlocks
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 09 May 2017 03:03:09 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001954#comment-16001954 ] 

Hudson commented on HBASE-17924:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-1.4 #726 (See [https://builds.apache.org/job/HBase-1.4/726/])
HBASE-17924 Consider sorting the row order when processing multi() ops (apurtell: rev 0f6a2c41133b2d800389be81f3aefe4589ec1625)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java


> Consider sorting the row order when processing multi() ops before taking rowlocks
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-17924
>                 URL: https://issues.apache.org/jira/browse/HBASE-17924
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0, 1.1.8
>            Reporter: Andrew Purtell
>            Assignee: Allan Yang
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-17924.patch, HBASE-17924.v0.patch, HBASE-17924.v2.patch, HBASE-17924.v3.patch, HBASE-17924.v4.patch, HBASE-17924.v5.patch
>
>
> When processing a batch mutation, we take row locks in whatever order the mutations were added to the multi op by the client.
>  
> {noformat}
> RSRpcServices#multi -> RSRpcServices#mutateRows -> HRegion#mutateRow -> HRegion#mutateRowsWithLocks -> HRegion#processRowsWithLocks
> {noformat}
> Or
> {noformat}
> RSRpcServices#multi -> RSRpcServices#doNonAtomicRegionMutation ->
>       HRegion#get 
>     | HRegion#append 
>     | HRegion#increment 
>     | HRegionServer#doBatchOp -> HRegion#batchMutate -> HRegion#doMiniBatchMutation
> {noformat}
>  
> multi() is fed by client APIs that accept a RowMutations object containing actions for multiple rows. The container for ops inside RowMutations is an ArrayList, which doesn't change the ordering of objects added to it. The protobuf implementation of the messages for multi ops do not reorder the list of actions. When processing multi ops we iterate over the actions in the order rehydrated from protobuf.
> We should discuss sorting the order of ops by row key when processing multi() ops before taking row locks. Does this make lock ordering more predictable for server side operations? Yes, but potentially surprising for the client, right? Is there any legitimate reason we should take locks out of row key sorted order because the client has structured the request as such?


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)