Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AE6A7200CA4 for ; Tue, 2 May 2017 19:07:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AD08E160B9D; Tue, 2 May 2017 17:07:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F2D7B160BAC for ; Tue, 2 May 2017 19:07:10 +0200 (CEST) Received: (qmail 77998 invoked by uid 500); 2 May 2017 17:07:10 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 77900 invoked by uid 99); 2 May 2017 17:07:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 May 2017 17:07:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8E6E3C13A5 for ; Tue, 2 May 2017 17:07:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id bFyO_kh_LtqH for ; Tue, 2 May 2017 17:07:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7D0F25FC84 for ; Tue, 2 May 2017 17:07:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8B0EAE0DAA for ; Tue, 2 May 2017 17:07:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B9FBE21DF8 for ; Tue, 2 May 2017 17:07:04 +0000 (UTC) Date: Tue, 2 May 2017 17:07:04 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17862) Condition that always returns true MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 02 May 2017 17:07:11 -0000 [ https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993292#comment-15993292 ] Hudson commented on HBASE-17862: -------------------------------- SUCCESS: Integrated in Jenkins build HBase-1.3-IT #36 (See [https://builds.apache.org/job/HBase-1.3-IT/36/]) HBASE-17862 Fix a condition that always returns true (chia7712: rev 8bfef58a4690abed1a201558282380b63efc708c) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java > Condition that always returns true > ---------------------------------- > > Key: HBASE-17862 > URL: https://issues.apache.org/jira/browse/HBASE-17862 > Project: HBase > Issue Type: Bug > Components: Client > Reporter: JC > Assignee: JC > Priority: Trivial > Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11 > > Attachments: 0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch > > > Hi > In recent github mirror of hbase, I've found the following code smell. > Path: hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java > {code} > 209 > 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o; > 211 if (this.columnOffset != null) { > 212 return this.getLimit() == this.getLimit() && > 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset()); > 214 } > {code} > It should be? > {code} > 212 return this.getLimit() == other.getLimit() && > {code} > This might be just a code smell as Bytes.equals can be enough for the return value but wanted to report just in case. > Thanks! -- This message was sent by Atlassian JIRA (v6.3.15#6346)