Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 4 May 2017 19:34:04 +0000 (UTC)
From: "Sean Busbey (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13056061.1489521916000.129977.1493926444273@Atlassian.JIRA>
In-Reply-To: <JIRA.13056061.1489521916000@Atlassian.JIRA>
References: <JIRA.13056061.1489521916000@Atlassian.JIRA> <JIRA.13056061.1489521916638@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-17786) Create LoadBalancer perf-tests
 (test balancer algorithm decoupled from workload)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 04 May 2017 19:34:09 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997306#comment-15997306 ] 

Sean Busbey commented on HBASE-17786:
-------------------------------------

{code}
   // Used to signal to the caller that the region(s) cannot be assigned
-  static final ServerName BOGUS_SERVER_NAME = ServerName.valueOf("bogus.example.com,1,1");
+  ServerName BOGUS_SERVER_NAME = ServerName.valueOf("bogus.example.com,1,1");
{code}

Why this change to make it mutable?

> Create LoadBalancer perf-tests (test balancer algorithm decoupled from workload)
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-17786
>                 URL: https://issues.apache.org/jira/browse/HBASE-17786
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Balancer, proc-v2
>            Reporter: stack
>            Assignee: Umesh Agashe
>              Labels: beginner
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17786.001.patch
>
>
> (Below is a quote from [~mbertozzi] taken from an internal issue that I'm moving out here)
> Add perf tools and keep monitored balancer performance (a BalancerPE-type thing).
> Most of the balancers should be instantiable without requiring a mini-cluster, and it easy to create tons of RegionInfo and ServerNames with a for loop.
> The balancer is just creating a map RegionInfo:ServerName.
> There are two methods to test roundRobinAssignment() and retainAssignment()
> {code}
> Map<ServerName, List<HRegionInfo>> roundRobinAssignment(
>     List<HRegionInfo> regions,
>     List<ServerName> servers
>   ) throws HBaseIOException; 
> Map<ServerName, List<HRegionInfo>> retainAssignment(
>     Map<HRegionInfo, ServerName> regions,
>     List<ServerName> servers
>   ) throws HBaseIOException;
> {code}
> There are a bunch of obvious optimization that everyone can see just by looking at the code. (like replacing array with set when we do contains/remove operations). It will be nice to have a baseline and start improving from there.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)