Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 532FB200C70 for ; Thu, 4 May 2017 19:22:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 51C6B160BB0; Thu, 4 May 2017 17:22:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 97BDE160B9B for ; Thu, 4 May 2017 19:22:07 +0200 (CEST) Received: (qmail 83065 invoked by uid 500); 4 May 2017 17:22:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 83054 invoked by uid 99); 4 May 2017 17:22:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 May 2017 17:22:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 44B06188A30 for ; Thu, 4 May 2017 17:22:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id KkMWFqrFPlVC for ; Thu, 4 May 2017 17:22:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 451605FB32 for ; Thu, 4 May 2017 17:22:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BD6EDE09BC for ; Thu, 4 May 2017 17:22:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 25DB821DEE for ; Thu, 4 May 2017 17:22:04 +0000 (UTC) Date: Thu, 4 May 2017 17:22:04 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17534) SecureBulkLoadClient squashes DoNotRetryIOExceptions from the server MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 04 May 2017 17:22:08 -0000 [ https://issues.apache.org/jira/browse/HBASE-17534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997109#comment-15997109 ] Hudson commented on HBASE-17534: -------------------------------- SUCCESS: Integrated in Jenkins build HBase-1.3-IT #38 (See [https://builds.apache.org/job/HBase-1.3-IT/38/]) HBASE-17534 Avoid re-wrapping IOExceptions as IOExceptions (elserj: rev 2ddb30c570ce239c4fb81213d468452709b14d78) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/SecureBulkLoadClient.java * (add) hbase-client/src/test/java/org/apache/hadoop/hbase/client/coprocessor/TestSecureBulkLoadClient.java > SecureBulkLoadClient squashes DoNotRetryIOExceptions from the server > -------------------------------------------------------------------- > > Key: HBASE-17534 > URL: https://issues.apache.org/jira/browse/HBASE-17534 > Project: HBase > Issue Type: Bug > Components: Client > Reporter: Josh Elser > Assignee: Josh Elser > Fix For: 1.4.0, 1.2.6, 1.3.2, 1.1.11 > > Attachments: HBASE-17534.001.branch-1.patch, HBASE-17534.002.branch-1.patch, HBASE-17534.003.branch-1.patch, HBASE-17534.004.branch-1.patch, HBASE-17534.005.branch-1.patch, HBASE-17534.006.branch-1.patch > > > While writing some tests against 1.x, I noticed that what should have been a DoNotRetryIOException sent to the client from a RegionServer was getting retried until it reached the hbase client retries limit. > Upon inspection, I found that the SecureBulkLoadClient was wrapping all Exceptions from the RPC as an IOException. I believe this is creating a case where the RPC system doesn't notice that there's a DNRIOException wrapped beneath it, thinking it's a transient error. > This results in clients having to wait for the retry limit to be reached before they get acknowledgement that something failed. -- This message was sent by Atlassian JIRA (v6.3.15#6346)