Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 25D18200C73 for ; Wed, 10 May 2017 09:51:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 24AA4160BC6; Wed, 10 May 2017 07:51:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6B78C160BA8 for ; Wed, 10 May 2017 09:51:08 +0200 (CEST) Received: (qmail 69294 invoked by uid 500); 10 May 2017 07:51:07 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 69283 invoked by uid 99); 10 May 2017 07:51:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 May 2017 07:51:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EE3AFC0EA2 for ; Wed, 10 May 2017 07:51:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id CachpC5BB1Kd for ; Wed, 10 May 2017 07:51:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DA36F5F27E for ; Wed, 10 May 2017 07:51:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 39D1CE0D50 for ; Wed, 10 May 2017 07:51:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4F24C21E14 for ; Wed, 10 May 2017 07:51:04 +0000 (UTC) Date: Wed, 10 May 2017 07:51:04 +0000 (UTC) From: "Chia-Ping Tsai (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-17343) Make Compacting Memstore default in 2.0 with BASIC as the default type MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 10 May 2017 07:51:09 -0000 [ https://issues.apache.org/jira/browse/HBASE-17343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-17343: ----------------------------------- Attachment: ut.v1.patch bq. Do we have a new issue for the compacting memstore problem? Or all in one patch? in one patch bq. I do not understand why do you say that the problem there is related specifically to CompactingMemStore Please see TestStore#testCreateScannerAndSnapshotConcurrently in ut.v1.patch bq. Can you please explain? We will lose the latest active segment when creating the scanner with the following execution order. # List pipelineList = pipeline.getSegments(); // getScanners # List snapshotList = snapshot.getAllSegments(); // getScanners # pipeline.pushHead(active); // snapshot # resetActive(); // snapshot # order = addToScanners(active, readPt, order, list); // getScanners Therefore, we should cache the active segment before getting the segments from pipeline. The side-effect is that we may have duplicate scanner but the scenario is rare and should be tolerated for ACID. > Make Compacting Memstore default in 2.0 with BASIC as the default type > ---------------------------------------------------------------------- > > Key: HBASE-17343 > URL: https://issues.apache.org/jira/browse/HBASE-17343 > Project: HBase > Issue Type: New Feature > Components: regionserver > Affects Versions: 2.0.0 > Reporter: ramkrishna.s.vasudevan > Assignee: Anastasia Braginsky > Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-17343-V01.patch, HBASE-17343-V02.patch, HBASE-17343-V04.patch, HBASE-17343-V05.patch, HBASE-17343-V06.patch, HBASE-17343-V07.patch, HBASE-17343-V08.patch, HBASE-17343-V09.patch, ut.v1.patch > > > FYI [~anastas], [~eshcar] and [~ebortnik]. -- This message was sent by Atlassian JIRA (v6.3.15#6346)