Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1A545200C77 for ; Mon, 1 May 2017 23:15:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 18D2B160BAE; Mon, 1 May 2017 21:15:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5FCE2160BA0 for ; Mon, 1 May 2017 23:15:07 +0200 (CEST) Received: (qmail 56537 invoked by uid 500); 1 May 2017 21:15:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 56526 invoked by uid 99); 1 May 2017 21:15:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 May 2017 21:15:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 1D9F3C01DB for ; Mon, 1 May 2017 21:15:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id jFVo5iPtHB3k for ; Mon, 1 May 2017 21:15:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3DA885FCE3 for ; Mon, 1 May 2017 21:15:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D8AC1E092E for ; Mon, 1 May 2017 21:15:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3F4F421DE5 for ; Mon, 1 May 2017 21:15:04 +0000 (UTC) Date: Mon, 1 May 2017 21:15:04 +0000 (UTC) From: "Umesh Agashe (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16549) Procedure v2 - Add new AM metrics MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 01 May 2017 21:15:08 -0000 [ https://issues.apache.org/jira/browse/HBASE-16549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991553#comment-15991553 ] Umesh Agashe commented on HBASE-16549: -------------------------------------- Hi [~appy], Thanks for your review feedback. I have changed the code as per your review comments. Regarding having member {{static ProcedureMetric metric}} in AssignProcedure etc., there is a threading issue as we discussed on Friday. Thanks, Umesh > Procedure v2 - Add new AM metrics > --------------------------------- > > Key: HBASE-16549 > URL: https://issues.apache.org/jira/browse/HBASE-16549 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Region Assignment > Affects Versions: 2.0.0 > Reporter: Matteo Bertozzi > Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: HBASE-16549-hbase-14614.v1.patch, HBASE-16549-hbase-14614.v2.patch, HBASE-16549-hbase-14614.v3.patch > > > With the new AM we can add a bunch of metrics > - assign/unassign time > - server crash time > - grouping related metrics? (how many batch we do, and similar?) -- This message was sent by Atlassian JIRA (v6.3.15#6346)