Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 5 May 2017 03:17:04 +0000 (UTC)
From: "Sean Busbey (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12935669.1454345926000.133243.1493954224373@Atlassian.JIRA>
In-Reply-To: <JIRA.12935669.1454345926000@Atlassian.JIRA>
References: <JIRA.12935669.1454345926000@Atlassian.JIRA> <JIRA.12935669.1454345926274@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-15199) Move jruby jar so only on
 hbase-shell module classpath; currently globally available
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 05 May 2017 03:17:09 -0000


    [ https://issues.apache.org/jira/browse/HBASE-15199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997752#comment-15997752 ] 

Sean Busbey commented on HBASE-15199:
-------------------------------------

{quote}
However, there is a catch - if JRUBY_HOME is set as environment variable and you use bin/start-hbase.sh, the jruby jar would appear in the classpath:
java.class.path=/a/jruby-1.6.8/lib/jruby.jar
{quote}

this part might not be HBASE-17878. One shouldn't have JRUBY_HOME exported in the environment when launching the server processes normally. You should only have it exported when you actually need your specific JRuby in the classpath.

> Move jruby jar so only on hbase-shell module classpath; currently globally available
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-15199
>                 URL: https://issues.apache.org/jira/browse/HBASE-15199
>             Project: HBase
>          Issue Type: Task
>          Components: dependencies, jruby, shell
>            Reporter: stack
>            Assignee: Xiang Li
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: 15199.txt, HBASE-15199.master.001.patch, HBASE-15199.master.002.patch, HBASE-15199.master.003.patch
>
>
> A suggestion that came up out of internal issue (filed by Mr Jan Van Besien) was to move the scope of the jruby include down so it is only a dependency for the hbase-shell. jruby jar brings in a bunch of dependencies (joda time for example) which can clash with the includes of others. Our Sean suggests that could be good to shut down exploit possibilities if jruby was not globally available. Only downside I can think is that it may no longer be available to our bin/*rb scripts if we move the jar but perhaps these can be changed so they can find the ruby jar in new location.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)