hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18099) FlushSnapshotSubprocedure should check the return value from Region#flush()
Date Wed, 24 May 2017 19:54:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023554#comment-16023554
] 

Ted Yu commented on HBASE-18099:
--------------------------------

I ran patch v2 thru all snapshot unit tests which passed.

>From hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.TestMobSnapshotFromClient-output.txt
:
{code}
2017-05-24 19:05:34,765 DEBUG [MemStoreFlusher.1] regionserver.HRegionFileSystem(462): Committing
store file hdfs://localhost:34968/user/hbase/test-data/f01c3a23-186d-4e09-9b8b-fd9b60840fda/data/default/test/55ad54ef83710bca3ffe6c5bf935abb2/.tmp/fam/22c69e9c6817408f952bba14175fc7c7
as hdfs://localhost:34968/user/hbase/test-data/f01c3a23-186d-4e09-9b8b-fd9b60840fda/data/default/test/55ad54ef83710bca3ffe6c5bf935abb2/fam/22c69e9c6817408f952bba14175fc7c7
2017-05-24 19:05:34,773 INFO  [MemStoreFlusher.1] regionserver.HStore(1010): Added hdfs://localhost:34968/user/hbase/test-data/f01c3a23-186d-4e09-9b8b-fd9b60840fda/data/default/test/55ad54ef83710bca3ffe6c5bf935abb2/fam/22c69e9c6817408f952bba14175fc7c7,
entries=2048, sequenceid=27, filesize=245.0 K
2017-05-24 19:05:34,775 INFO  [MemStoreFlusher.1] regionserver.HRegion(2742): Finished memstore
flush of ~64 KB/65536, currentsize=37.25 KB/38144 for region test,5,1495652731733.55ad54ef83710bca3ffe6c5bf935abb2.
in 473ms, sequenceid=27, compaction requested=false
2017-05-24 19:05:34,775 DEBUG [rs(cn012.l42scl.hortonworks.com,35700,1495652693950)-snapshot-pool38-thread-2]
snapshot.FlushSnapshotSubprocedure$RegionSnapshotTask(107): Waited 120 ms for flush to complete
{code}

> FlushSnapshotSubprocedure should check the return value from Region#flush()
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-18099
>                 URL: https://issues.apache.org/jira/browse/HBASE-18099
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>         Attachments: 18099.v1.txt, 18099.v2.txt
>
>
> In the following thread:
> http://search-hadoop.com/m/HBase/YGbbMXkeHlI9zo
> Jacob described the scenario where data from certain region were missing in the snapshot.
> Here was related region server log:
> https://pastebin.com/1ECXjhRp
> He pointed out that concurrent flush from MemStoreFlusher.1 thread was not initiated
from the thread pool for snapshot.
> In RegionSnapshotTask#call() method there is this:
> {code}
>           region.flush(true);
> {code}
> The return value is not checked.
> In HRegion#flushcache(), Result.CANNOT_FLUSH may be returned due to:
> {code}
>           String msg = "Not flushing since "
>               + (writestate.flushing ? "already flushing"
>               : "writes not enabled");
> {code}
> This implies that FlushSnapshotSubprocedure may incorrectly skip waiting for the concurrent
flush to complete.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message