hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18079) [C++] Optimize ClientBootstrap in ConnectionPool
Date Sat, 27 May 2017 01:25:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027104#comment-16027104
] 

Enis Soztutar commented on HBASE-18079:
---------------------------------------

[~xiaobingo] tests are failing for me with this patch, especially: 
{code}
FAILURE TestConnectionPool TestOnlyCreateMultipleDispose: connection/connection-pool-test.cc:90
Actual function call count doesn't match EXPECT_CALL((*mock_cf), MakeBootstrap())...
         Expected: to be called twice
           Actual: called once - unsatisfied and active
{code}


> [C++] Optimize ClientBootstrap in ConnectionPool
> ------------------------------------------------
>
>                 Key: HBASE-18079
>                 URL: https://issues.apache.org/jira/browse/HBASE-18079
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HBASE-18079-HBASE-14850.000.patch
>
>
> ConnectionPool creates an instance of wangle::ClientBootstrap for every new connection
(i.e. Wangle pipeline) and cache it hereafter, it is unnecessary. Instead, ConnectionPool
can maintain a single ClientBootstrap instance in its members.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message