hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18060) Backport to branch-1 HBASE-9774 HBase native metrics and metric collection for coprocessors
Date Fri, 19 May 2017 05:38:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016917#comment-16016917
] 

Hadoop QA commented on HBASE-18060:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 25s {color} | {color:blue}
Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} @author {color} | {color:red} 0m 0s {color} | {color:red}
The patch appears to contain 1 @author tags which the community has agreed to not allow in
code contributions. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color}
| {color:green} The patch appears to include 14 new or modified test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s {color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 10s {color}
| {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 2s {color} | {color:green}
branch-1.3 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 8s {color} | {color:green}
branch-1.3 passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 6s {color}
| {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 54s {color}
| {color:green} branch-1.3 passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue}
Skipped patched modules with no Java source: hbase-resource-bundle hbase-assembly . {color}
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 57s {color} | {color:red}
hbase-server in branch-1.3 has 1 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 0s {color} | {color:green}
branch-1.3 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 55s {color} |
{color:green} branch-1.3 passed with JDK v1.7.0_80 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s {color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 22s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 11s {color} |
{color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 19s {color} | {color:red}
root-jdk1.8.0_131 with JDK v1.8.0_131 generated 8 new + 15 unchanged - 0 fixed = 23 total
(was 15) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 9s {color} | {color:red}
hbase-metrics-jdk1.8.0_131 with JDK v1.8.0_131 generated 8 new + 0 unchanged - 0 fixed = 8
total (was 0) {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 26s {color} |
{color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 19s {color} | {color:red}
root-jdk1.7.0_80 with JDK v1.7.0_80 generated 8 new + 15 unchanged - 0 fixed = 23 total (was
15) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 10s {color} | {color:red}
hbase-metrics-jdk1.7.0_80 with JDK v1.7.0_80 generated 8 new + 0 unchanged - 0 fixed = 8 total
(was 0) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 21s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m 32s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 3s {color} | {color:green}
The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 19m 39s {color}
| {color:green} The patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2
2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 2m 59s {color}
| {color:green} the patch passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue}
Skipped patched modules with no Java source: hbase-resource-bundle . hbase-assembly {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m 49s {color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 19s {color} |
{color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m 17s {color} |
{color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 7s {color} | {color:green}
hbase-resource-bundle in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 50s {color} | {color:green}
hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 13s {color} | {color:green}
hbase-metrics-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 120m 0s {color} | {color:green}
root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 23s {color} | {color:green}
hbase-assembly in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 25s {color} | {color:green}
hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 25s {color} | {color:green}
hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 28s {color} | {color:green}
hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 21s {color} | {color:green}
hbase-metrics in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 83m 6s {color} | {color:green}
hbase-server in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 2m 5s {color} | {color:red}
The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 288m 26s {color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:e1e11ad |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12868853/HBASE-18060.branch-1.3.v1.patch
|
| JIRA Issue | HBASE-18060 |
| Optional Tests |  asflicense  javac  javadoc  unit  xml  compile  findbugs  hadoopcheck
 hbaseanti  checkstyle  |
| uname | Linux a2ed35777ec2 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/hbase.sh |
| git revision | branch-1.3 / e9aa49f |
| Default Java | 1.7.0_80 |
| Multi-JDK versions |  /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-oracle:1.7.0_80
|
| @author | https://builds.apache.org/job/PreCommit-HBASE-Build/6838/artifact/patchprocess/author-tags.txt
|
| findbugs | v3.0.0 |
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/6838/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/6838/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_131.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/6838/artifact/patchprocess/diff-compile-javac-hbase-metrics-jdk1.8.0_131.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/6838/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_80.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/6838/artifact/patchprocess/diff-compile-javac-hbase-metrics-jdk1.7.0_80.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/6838/testReport/ |
| asflicense | https://builds.apache.org/job/PreCommit-HBASE-Build/6838/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C: hbase-resource-bundle hbase-common hbase-metrics-api . hbase-assembly hbase-examples
hbase-hadoop-compat hbase-hadoop2-compat hbase-metrics hbase-server U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/6838/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Backport to branch-1 HBASE-9774 HBase native metrics and metric collection for coprocessors
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-18060
>                 URL: https://issues.apache.org/jira/browse/HBASE-18060
>             Project: HBase
>          Issue Type: New Feature
>    Affects Versions: 1.4.0, 1.3.2, 1.5.0
>            Reporter: Vincent Poon
>            Assignee: Vincent Poon
>         Attachments: HBASE-18060.branch-1.3.v1.patch, HBASE-18060.branch-1.v1.patch
>
>
> I'd like to explore backporting HBASE-9774 to branch-1, as the ability for coprocessors
to report custom metrics through HBase is useful for us, and if we have coprocessors use the
native API, a re-write won't be necessary after an upgrade to 2.0.
> The main issues I see so far are:
> - the usage of Java 8 language features.  Seems we can work around this as most of it
is syntactic sugar.  Will need to find a backport for LongAdder
> - dropwizard 3.1.2 in Master.  branch-1 is still on yammer metrics 2.2.  Not sure if
these can coexist just for this feature



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message