hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18043) Institute a hard limit for individual cell size that cannot be overridden by clients
Date Sat, 13 May 2017 17:30:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009422#comment-16009422
] 

Jonathan Hsieh commented on HBASE-18043:
----------------------------------------

Any reason why the cell's row key/column fam/column is not in the error message?   Also the
include the max size configuration name in the message?  This would help with debugging and
providing the operator hints if clients claim data is "missing".

{code}
884	        int size = CellUtil.estimatedSerializedSizeOf(cells.current());
885	        if (size > r.maxCellSize) {
886	          String msg = "Cell with size " + size + " exceeds limit of " + r.maxCellSize
+ " bytes";
887	          if (LOG.isDebugEnabled()) {
888	            LOG.debug(msg);
889	          }
890	          throw new DoNotRetryIOException(msg);
891	        }
{code}

Also please add a release note about the new config.

> Institute a hard limit for individual cell size that cannot be overridden by clients
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-18043
>                 URL: https://issues.apache.org/jira/browse/HBASE-18043
>             Project: HBase
>          Issue Type: Improvement
>          Components: IPC/RPC, regionserver
>    Affects Versions: 2.0.0
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-18043-branch-1.patch, HBASE-18043-branch-1.patch, HBASE-18043.patch,
HBASE-18043.patch, HBASE-18043.patch
>
>
> For sake of service protection we should not give absolute trust to clients regarding
resource limits that can impact stability, like cell size limits. We should add a server side
configuration that sets a hard limit for individual cell size that cannot be overridden by
the client. We can keep the client side check, because it's expensive to reject a RPC that
has already come in. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message