hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18029) Backport HBASE-15296 to branch-1
Date Fri, 12 May 2017 22:43:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008848#comment-16008848

Appy commented on HBASE-18029:

I haven't thought this completely through, but throwing it out for discussion:
- Refactor out current nested classes to StoreFileReader / StoreFileWriter.
- Create dummy classes. For eg. {{class Reader extends StoreFileReader}}
- Return StoreFile.Reader from fns in StoreFile (keeps compat)
- return StoreFileReader from CP functions
- caveat being doing explicit casting in non-public parts of code. In this case, {{private
Reader open(...)}}. But if we do se, we should explicitly comment dummy classes saying what
they are and why.
(uploading a quick patch)

+1 for interfaces, but that's orthogonal, right? (unless am missing something)
[~Apache9]. Took me time to get back since i was on leave for majority of week.

> Backport HBASE-15296 to branch-1
> --------------------------------
>                 Key: HBASE-18029
>                 URL: https://issues.apache.org/jira/browse/HBASE-18029
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Duo Zhang

This message was sent by Atlassian JIRA

View raw message