hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18027) Replication should respect RPC size limits when batching edits
Date Wed, 31 May 2017 01:08:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030460#comment-16030460
] 

Hudson commented on HBASE-18027:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-1.4 #752 (See [https://builds.apache.org/job/HBase-1.4/752/])
HBASE-18027 HBaseInterClusterReplicationEndpoint should respect RPC (apurtell: rev 140c559a3a2528bc1485852bb9b5251901d58798)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java
* (add) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicator.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALKey.java


> Replication should respect RPC size limits when batching edits
> --------------------------------------------------------------
>
>                 Key: HBASE-18027
>                 URL: https://issues.apache.org/jira/browse/HBASE-18027
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 2.0.0, 1.4.0, 1.3.1
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-18027-branch-1.patch, HBASE-18027-branch-1.patch, HBASE-18027-branch-1.patch,
HBASE-18027-branch-1.patch, HBASE-18027.patch, HBASE-18027.patch, HBASE-18027.patch, HBASE-18027.patch,
HBASE-18027.patch, HBASE-18027.patch, HBASE-18027.patch, HBASE-18027.patch
>
>
> In HBaseInterClusterReplicationEndpoint#replicate we try to replicate in batches. We
create N lists. N is the minimum of configured replicator threads, number of 100-waledit batches,
or number of current sinks. Every pending entry in the replication context is then placed
in order by hash of encoded region name into one of these N lists. Each of the N lists is
then sent all at once in one replication RPC. We do not test if the sum of data in each N
list will exceed RPC size limits. This code presumes each individual edit is reasonably small.
Not checking for aggregate size while assembling the lists into RPCs is an oversight and can
lead to replication failure when that assumption is violated.
> We can fix this by generating as many replication RPC calls as we need to drain a list,
keeping each RPC under limit, instead of assuming the whole list will fit in one.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message