hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18026) ProtobufUtil seems to do extra array copying
Date Mon, 15 May 2017 05:36:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010000#comment-16010000
] 

Anoop Sam John commented on HBASE-18026:
----------------------------------------

Am fine with this addendum.  And I suggest revering the change in master branch as any way
it is not useful and needed.  For other branches, I also suggest adding the addendum.  Ping
[~apurtell]

> ProtobufUtil seems to do extra array copying
> --------------------------------------------
>
>                 Key: HBASE-18026
>                 URL: https://issues.apache.org/jira/browse/HBASE-18026
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 1.3.2
>            Reporter: Vincent Poon
>            Assignee: Vincent Poon
>            Priority: Minor
>             Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11
>
>         Attachments: HBASE-18026.addendum.patch, HBASE-18026.branch-1.v1.patch, HBASE-18026.master.v1.patch
>
>
> In ProtobufUtil, the protobuf fields are copied into an array using toByteArray().  These
are then passed into the KeyValue constructor which does another copy.
> It seems like we can avoid a copy here by using HBaseZeroCopyByteString#zeroCopyGetBytes()
?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message