hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17992) The snapShot TimeoutException causes the cleanerChore thread to fail to complete the archive correctly
Date Mon, 08 May 2017 04:09:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000234#comment-16000234
] 

Ted Yu commented on HBASE-17992:
--------------------------------

{code}
+        while(!exec.isTerminated()){
+          Thread.sleep(2000);
{code}
Should there be a bound on the total duration of waiting ?
{code}
+    this.waittimeAttempts =
+        this.coord.getRpcs().getConfiguration()
+            .getLong("hbase.procedure.clearznodes.waittime", 3000l);
{code}
Add dot between "wait" and "time" in the config key name. If you keep Attempts in variable
name, you can use waitTimeBetweenAttempts.
{code}
+  private final Map<String,Future<Void>> submitSubprocedures=
+      new HashMap<String, Future<Void>>();
{code}
Add comment for what purpose the map serves.

> The snapShot TimeoutException causes the cleanerChore thread to fail to complete the
archive correctly
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-17992
>                 URL: https://issues.apache.org/jira/browse/HBASE-17992
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 0.98.10, 1.3.0
>            Reporter: Bo Cui
>         Attachments: hbase-17992.patch
>
>
> The problem is that when the snapshot occurs TimeoutException  or other Exceptions, there
is no correct delete /hbase/.hbase-snapshot/tmp, which causes the cleanerChore to fail to
complete the archive correctly.
> Modifying the configuration parameter (hbase.snapshot.master.timeout.millis = 600000)
only reduces the probability of the problem occurring.
> So the solution to the problem is: multi-Threaded exceptions or TimeoutExceptions, the
Main-thread must wait until all the tasks are finished or canceled, the Main-thread can be
cleared /hbase/.hbase-snapshot/tmp/snapshotName.Otherwise the task is likely to write /hbase/.hbase-snapshot/tmp/snapshotName/region
- mainfest
> The problem exists in disabledTableSnapshot and enabledTableSnapshot, because I'm currently
using the disabledTableSnapshot, so I provide the patch of disabledTableSnapshot



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message