hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17938) General fault - tolerance framework for backup/restore operations
Date Wed, 03 May 2017 23:07:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995868#comment-15995868
] 

Ted Yu commented on HBASE-17938:
--------------------------------

Somehow review board doesn't accept my review comments.
{code}
      conn = ConnectionFactory.createConnection(getConf());
{code}
Where is conn released ?
{code}
      firstBackup = savedStartCode == null || Long.parseLong(savedStartCode) == 0L;
{code}
What if a second client comes and sees the savedStartCode as zero (written by line 130) ?

There is duplicate code between executeForTesting() and execute(). Extract common code.


> General fault - tolerance framework for backup/restore operations
> -----------------------------------------------------------------
>
>                 Key: HBASE-17938
>                 URL: https://issues.apache.org/jira/browse/HBASE-17938
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17938-v1.patch, HBASE-17938-v2.patch, HBASE-17938-v3.patch,
HBASE-17938-v4.patch
>
>
> The framework must take care of all general types of failures during backup/ restore
and restore system to the original state in case of a failure.
> That won't solve all the possible issues  but we have a separate JIRAs for them as a
sub-tasks of HBASE-15277



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message