hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17887) TestAcidGuarantees fails frequently
Date Tue, 09 May 2017 14:23:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002760#comment-16002760
] 

Chia-Ping Tsai commented on HBASE-17887:
----------------------------------------

bq. should we really have the currentScanners?
Yes, we have the currentScanners. 

bq.  If so then the point above of closing it does not apply.
I will fix it in next patch.

bq. Because in the patch that you have given SCannerTicket has to be exposed to Store.java
as it is LimitedPRivate and Coprocs may need to know about that. Instead passing a list of
scanners may be much simpler and easy to comprehend?
You are right.

bq. Can we just pass on list of memstoreScanners to the getScanners API in STore along with
the files over which scan has to be created.
Pardon me, could you tell me more details?
We could get rid of ticker by passing a list of memstoreScanners on to ChangedReadersObserver.
{code}
  /**
   * Notify observers.
   * @throws IOException e
   */
  void updateReaders(List<StoreFile> sfs, List<KeyValueScanner> memStoreScanners)
throws IOException;
{code}
StoreScanner can only updates the file scanner in resetScannerStack.

Thanks for your suggestion. [~ram_krish]

> TestAcidGuarantees fails frequently
> -----------------------------------
>
>                 Key: HBASE-17887
>                 URL: https://issues.apache.org/jira/browse/HBASE-17887
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 2.0.0
>            Reporter: Umesh Agashe
>            Assignee: Chia-Ping Tsai
>            Priority: Blocker
>             Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.4.1
>
>         Attachments: HBASE-17887.branch-1.v0.patch, HBASE-17887.branch-1.v1.patch, HBASE-17887.branch-1.v1.patch,
HBASE-17887.branch-1.v2.patch, HBASE-17887.branch-1.v2.patch, HBASE-17887.branch-1.v3.patch,
HBASE-17887.branch-1.v4.patch, HBASE-17887.branch-1.v4.patch, HBASE-17887.branch-1.v4.patch,
HBASE-17887.ut.patch, HBASE-17887.v0.patch, HBASE-17887.v1.patch, HBASE-17887.v2.patch, HBASE-17887.v3.patch
>
>
> As per the flaky tests dashboard here: https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html,
It fails 30% of the time.
> While working on HBASE-17863, a few verification builds on patch failed due to TestAcidGuarantees
didn't pass. IMHO, the changes for HBASE-17863 are unlikely to affect get/ put path.
> I ran the test with and without the patch several times locally and found that TestAcidGuarantees
fails without the patch similar number of times.
> Opening blocker, considering acid guarantees are critical to HBase.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message