hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sudeep Sunthankar (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.
Date Wed, 03 May 2017 09:37:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994540#comment-15994540
] 

Sudeep Sunthankar edited comment on HBASE-17576 at 5/3/17 9:36 AM:
-------------------------------------------------------------------

V10 patch for Multi Requests.
Hi [~enis], Addressed below points

# {quote}You should use CHECK macros from glog like this: {quote}
# {quote}Remove these commented out code{quote}
# {quote}Simple client does not write test2 and testextra columns, why are you adding them
to the list of gets: {quote}
-- I added them as I couldn't run the unit tests on mini cluster. Have removed for now.
# {quote}Result->DebugString() already prints out the Cell information, no? Why are you
doing extra logging inside this if{quote}
-- Same as above
# {quote}No need for checking the exception type in table.cc: {quote}
-- Removed, throwing std::runtime_error.
# {quote}std::vector<std::shared_ptr<hbase::Get>> is already an instance of std::vector<std::shared_ptr<Row>>,
no? You should not need to copy the vector.{quote}
-- We can't directly pass a vector of Gets, to a function accepting vector of Row, as it results
in a build error. I have changed it to pass the begin() and end() iterators instead of copying
the Gets to a new Row vector.

--
Thanks


was (Author: sudeeps):
V10 patch for Multi Requests

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -----------------------------------------------------------------
>
>                 Key: HBASE-17576
>                 URL: https://issues.apache.org/jira/browse/HBASE-17576
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>            Assignee: Sudeep Sunthankar
>         Attachments: HBASE-17576.HBASE-14850.v10.patch, HBASE-17576.HBASE-14850.v1.patch,
HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, HBASE-17576.HBASE-14850.v4.patch,
HBASE-17576.HBASE-14850.v5.patch, HBASE-17576.HBASE-14850.v6.patch, HBASE-17576.HBASE-14850.v7.patch,
HBASE-17576.HBASE-14850.v8.patch, HBASE-17576.HBASE-14850.v9.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message