hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16466) HBase snapshots support in VerifyReplication tool to reduce load on live HBase cluster with large tables
Date Mon, 01 May 2017 23:36:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991793#comment-15991793
] 

Andrew Purtell commented on HBASE-16466:
----------------------------------------

The change to TableMapReduceUtil is unrelated. Please remove it. If you want this this change
in the code, file a new JIRA for it and we can get that committed separately. It's a nontrivial
behavioral change.

Sorry to pick on nits but this patch does not conform to our coding standards. See chahttps://hbase.apache.org/book.html#common.patch.feedback
which refers https://www.oracle.com/technetwork/java/index-135089.html . That's a lot to read,
so let me specifically address what bothers the eye:

Braces on the same line, please.

{code}
if () {
} else { 
}
{code}

not 

{code}
if () 
{
}
else
{ 
}
{code}

Spaces between keywords and parentheses please.

Don't comment out code
{code}
      //deleteDirectories(conf, snapshotTempPath);
{code}
If you don't want it in there, remove it. 

If anything, the changes made to a file should look the same as the code above and below.


> HBase snapshots support in VerifyReplication tool to reduce load on live HBase cluster
with large tables
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-16466
>                 URL: https://issues.apache.org/jira/browse/HBASE-16466
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbase
>    Affects Versions: 0.98.21
>            Reporter: Sukumar Maddineni
>            Assignee: Maddineni Sukumar
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16466.branch-1.3.001.patch, HBASE-16466.v1.patch, HBASE-16466.v2.patch,
HBASE-16466.v3.patch
>
>
> As of now VerifyReplicatin tool is running using normal HBase scanners. If you  want
to run VerifyReplication multiple times on a production live cluster with large tables then
it creates extra load on HBase layer. So if we implement snapshot based support then both
in source and target we can read data from snapshots which reduces load on HBase



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message