hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16392) Backup delete fault tolerance
Date Thu, 25 May 2017 18:16:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025146#comment-16025146
] 

Ted Yu commented on HBASE-16392:
--------------------------------

For restoreFromSnapshot() :
{code}
+      if (snapshotExists(admin, snapshotName)) {
+        admin.disableTable(BackupSystemTable.getTableName(conf));
+        admin.restoreSnapshot(snapshotName);
+        admin.enableTable(BackupSystemTable.getTableName(conf));
{code}
What if one of the 3 actions above fails ?
{code}
+        // In this case we log WARN and proceed
+        LOG.error("Could not restore backup system table. Snapshot " + snapshotName+
{code}
Comment and actual log level are different.
{code}
+  protected static boolean snapshotExists(Admin admin, String snapshotName) throws IOException
{
{code}
TableBackupClient.java already has snapshotExists() method.
{code}
+  private Delete createDeleteForDeleteOperation() {
{code}
createDeleteForDeleteOperation -> createDeleteForBackupDeleteOperation

> Backup delete fault tolerance
> -----------------------------
>
>                 Key: HBASE-16392
>                 URL: https://issues.apache.org/jira/browse/HBASE-16392
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>              Labels: backup
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16392-v1.patch
>
>
> Backup delete modified file system and backup system table. We have to make sure that
operation is atomic, durable and isolated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message