hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15602) Clean up using directives in cc files.
Date Tue, 30 May 2017 22:08:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030228#comment-16030228

Enis Soztutar commented on HBASE-15602:

[~Scott] thanks for working on this. It is a big patch, let me check whether it still applies.
Probably needs rebasing. 

bq. I had to make a some guesses at what might be the desired style. Feel free to tell me
where I need to make more changes. (i.e. I may have ended up under-using using statements
for someone's taste.)
The standard practice is to use the clang-format tool to format the patches automatically
so that everyone will use the same exact styling. There is a script under {{bin/format-code.sh}}
which can be run inside the docker environment (bin/start-docker.sh). 

bq. I didn't touch any -test.cc files. I can do these if desired.
These are lower priority, but the cleaner the better. We can do a different issue. 

bq. While compiling, I encountered quite a few gcc warnings (primarily on constructor initializer
order.) I have a further patch which attempts to clean all those up.
Sounds good. The patch is pretty big anyways, let's do a follow up patch. 

> Clean up using directives in cc files.
> --------------------------------------
>                 Key: HBASE-15602
>                 URL: https://issues.apache.org/jira/browse/HBASE-15602
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: HBASE-14850
>            Reporter: Elliott Clark
>            Assignee: Scott Hunt
>              Labels: beginner, easy, starter
>         Attachments: HBASE-15602.HBASE-14850.patch
> There's a ton of files that just barf out all of folly, wangle, and hbase into the global
namespace. We should use the using directive better than that when possible.

This message was sent by Atlassian JIRA

View raw message