hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Hunt (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-15602) Clean up using directives in cc files.
Date Mon, 22 May 2017 22:28:04 GMT

     [ https://issues.apache.org/jira/browse/HBASE-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Scott Hunt updated HBASE-15602:
-------------------------------
    Attachment: HBASE-15602.HBASE-14850.patch

This is bigger than I would have liked.
My first goal (though not in the description) was to remove usings from header files (because
that can really do some bad/unexpected stuff.)
Second goal was to remove or simplify most of the usings in source files, especially instances
of using namespace.
I tried to make sure all changes resulted in lines under 100 characters.

I had to make a some guesses at what might be the desired style.  Feel free to tell me where
I need to make more changes.  (i.e. I may have ended up under-using using statements for someone's
taste.)

Notes:
I didn't touch any -test.cc files.  I can do these if desired.
While compiling, I encountered quite a few gcc warnings (primarily on constructor initializer
order.) I have a further patch which attempts to clean all those up.

> Clean up using directives in cc files.
> --------------------------------------
>
>                 Key: HBASE-15602
>                 URL: https://issues.apache.org/jira/browse/HBASE-15602
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Elliott Clark
>              Labels: beginner, easy, starter
>         Attachments: HBASE-15602.HBASE-14850.patch
>
>
> There's a ton of files that just barf out all of folly, wangle, and hbase into the global
namespace. We should use the using directive better than that when possible.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message