Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 28 Apr 2017 11:13:04 +0000 (UTC)
From: "Shinya Yoshida (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13066589.1493102023000.77835.1493377984136@Atlassian.JIRA>
In-Reply-To: <JIRA.13066589.1493102023000@Atlassian.JIRA>
References: <JIRA.13066589.1493102023000@Atlassian.JIRA> <JIRA.13066589.1493102023651@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-17957)  Custom metrics of replicate
 endpoints don't prepend "source." to global metrics
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 28 Apr 2017 11:13:09 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988658#comment-15988658 ] 

Shinya Yoshida commented on HBASE-17957:
----------------------------------------

Some of UTs failed, but it seems to me the failed UTs are not produced by my patch(but I'm not sure).
Could someone confirm whether my patch broke tests or not?

>  Custom metrics of replicate endpoints don't prepend "source." to global metrics
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-17957
>                 URL: https://issues.apache.org/jira/browse/HBASE-17957
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 2.0.0, 1.4.0, 0.98.22
>            Reporter: Shinya Yoshida
>            Assignee: Shinya Yoshida
>            Priority: Minor
>         Attachments: HBASE-17957.master.001.patch, HBASE-17957.master.002.patch
>
>
> Custom metrics for custom replication endpoints is introduced by [HBASE-16448].
> The name of local custom metrics follows the "source.id.metricsName" format, but the name of global custom metrics doesn't follow the "source.metricsName" format.
> Ex:
> {code}
> // default metrics
> "source.2.shippedOps" : 1234, // peer local
> "source.shippedOps" : 12345, // global
> // custom metrics
> "source.1.failed.start" : 1, // peer local
> "failed.start" : 1, // global
> {code}
> When we consider that default metrics do so, it should be "source.metricsName" like:
> {code}
> "source.1.failed.start" : 1,
> "source.failed.start" : 1,
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)