Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 72548200C63 for ; Thu, 27 Apr 2017 05:33:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 70F74160BB4; Thu, 27 Apr 2017 03:33:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B70BB160BA8 for ; Thu, 27 Apr 2017 05:33:07 +0200 (CEST) Received: (qmail 665 invoked by uid 500); 27 Apr 2017 03:33:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 654 invoked by uid 99); 27 Apr 2017 03:33:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Apr 2017 03:33:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6C6F3D5C39 for ; Thu, 27 Apr 2017 03:33:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id UmZWOyJjgzJ9 for ; Thu, 27 Apr 2017 03:33:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3A4D55F306 for ; Thu, 27 Apr 2017 03:33:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8CA98E069F for ; Thu, 27 Apr 2017 03:33:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 46DD921DDF for ; Thu, 27 Apr 2017 03:33:04 +0000 (UTC) Date: Thu, 27 Apr 2017 03:33:04 +0000 (UTC) From: "Shinya Yoshida (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17957) Custom metrics of replicate endpoints don't prepend "source." to global metrics MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 27 Apr 2017 03:33:08 -0000 [ https://issues.apache.org/jira/browse/HBASE-17957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985935#comment-15985935 ] Shinya Yoshida commented on HBASE-17957: ---------------------------------------- I've uploaded patch v2 which is same with v1 and retriggered QA. > Custom metrics of replicate endpoints don't prepend "source." to global metrics > -------------------------------------------------------------------------------- > > Key: HBASE-17957 > URL: https://issues.apache.org/jira/browse/HBASE-17957 > Project: HBase > Issue Type: Bug > Components: Replication > Affects Versions: 2.0.0, 1.4.0, 0.98.22 > Reporter: Shinya Yoshida > Assignee: Shinya Yoshida > Priority: Minor > Attachments: HBASE-17957.master.001.patch, HBASE-17957.master.002.patch > > > Custom metrics for custom replication endpoints is introduced by [HBASE-16448]. > The name of local custom metrics follows the "source.id.metricsName" format, but the name of global custom metrics doesn't follow the "source.metricsName" format. > Ex: > {code} > // default metrics > "source.2.shippedOps" : 1234, // peer local > "source.shippedOps" : 12345, // global > // custom metrics > "source.1.failed.start" : 1, // peer local > "failed.start" : 1, // global > {code} > When we consider that default metrics do so, it should be "source.metricsName" like: > {code} > "source.1.failed.start" : 1, > "source.failed.start" : 1, > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)