Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EE33F200C6E for ; Mon, 24 Apr 2017 06:23:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id ECDB7160BB1; Mon, 24 Apr 2017 04:23:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 400CE160BA6 for ; Mon, 24 Apr 2017 06:23:07 +0200 (CEST) Received: (qmail 86705 invoked by uid 500); 24 Apr 2017 04:23:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 86694 invoked by uid 99); 24 Apr 2017 04:23:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Apr 2017 04:23:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D782E1A04B9 for ; Mon, 24 Apr 2017 04:23:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id wSRFOeV1epEA for ; Mon, 24 Apr 2017 04:23:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D71E25F20C for ; Mon, 24 Apr 2017 04:23:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6756CE0BD5 for ; Mon, 24 Apr 2017 04:23:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 11A0F21B56 for ; Mon, 24 Apr 2017 04:23:04 +0000 (UTC) Date: Mon, 24 Apr 2017 04:23:04 +0000 (UTC) From: "Xiang Li (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17947) Location of Examples.proto is wrong in comment of RowCountEndPoint.java MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 24 Apr 2017 04:23:08 -0000 [ https://issues.apache.org/jira/browse/HBASE-17947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980712#comment-15980712 ] Xiang Li commented on HBASE-17947: ---------------------------------- Thanks the comment from [~jingcheng.du]! Patch 001 for master branch is uploaded to address Jingcheng's comment! The JIRA meant to change the incorrect patch only, while the removal of "located under" was only trying to make it feel better when reading. Either is ok for me. > Location of Examples.proto is wrong in comment of RowCountEndPoint.java > ----------------------------------------------------------------------- > > Key: HBASE-17947 > URL: https://issues.apache.org/jira/browse/HBASE-17947 > Project: HBase > Issue Type: Bug > Components: Coprocessors > Reporter: Xiang Li > Assignee: Xiang Li > Priority: Trivial > Labels: easyfix > Fix For: 2.0.0 > > Attachments: HBASE-17947.master.000.patch, HBASE-17947.master.001.patch > > > In the comment of RowCountEndpoint.java > {code} > /** > * Sample coprocessor endpoint exposing a Service interface for counting rows and key values. > * > *

> * For the protocol buffer definition of the RowCountService, see the source file located under > * hbase-server/src/main/protobuf/Examples.proto. > *

> */ > {code} > Examples.proto is not under hbase-server/src/main/protobuf/, but under hbase-examples/src/main/protobuf/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)