Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 11 Apr 2017 01:41:41 +0000 (UTC)
From: "Chia-Ping Tsai (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13062774.1491800155000.252600.1491874901782@Atlassian.JIRA>
In-Reply-To: <JIRA.13062774.1491800155000@Atlassian.JIRA>
References: <JIRA.13062774.1491800155000@Atlassian.JIRA> <JIRA.13062774.1491800155931@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (HBASE-17897)
 StripeStoreFileManager#nonOpenRowCompare use the wrong comparison function
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 11 Apr 2017 01:41:46 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963727#comment-15963727 ] 

Chia-Ping Tsai edited comment on HBASE-17897 at 4/11/17 1:41 AM:
-----------------------------------------------------------------

bq. The byte arrays are row bytes only? There are no other components of the KeyValue serialized? If so, +1.
Another explanation is that the original comparison function is the Bytes.compareTo(byte[]. int, int, byte[], int, int); see HBASE-13998.


was (Author: chia7712):
bq. The byte arrays are row bytes only? There are no other components of the KeyValue serialized? If so, +1.
A another explanation is that the original comparison function is the Bytes.compareTo(byte[]. int, int, byte[], int, int); see HBASE-13998.

> StripeStoreFileManager#nonOpenRowCompare use the wrong comparison function
> --------------------------------------------------------------------------
>
>                 Key: HBASE-17897
>                 URL: https://issues.apache.org/jira/browse/HBASE-17897
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>         Attachments: HBASE-17897.failed.patch, HBASE-17897.v0.patch, HBASE-17897.v0.patch
>
>
> {noformat}
>   private final int nonOpenRowCompare(byte[] k1, byte[] k2) {
>     assert !isOpen(k1) && !isOpen(k2);
>     return cellComparator.compareRows(new KeyOnlyKeyValue(k1), k2, 0, k2.length);
>   }
> {noformat}
> The inputs aren't KeyValue format, so it is wrong to use KeyOnlyKeyValue to parse the row.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)