Return-Path: <issues-return-287261-archive-asf-public=cust-asf.ponee.io@hbase.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id B0789200C5B
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 27 Apr 2017 19:35:08 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id AF0A1160BA7; Thu, 27 Apr 2017 17:35:08 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 025F8160B9E
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 27 Apr 2017 19:35:07 +0200 (CEST)
Received: (qmail 38712 invoked by uid 500); 27 Apr 2017 17:35:07 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 38701 invoked by uid 99); 27 Apr 2017 17:35:07 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Apr 2017 17:35:07 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 944C4C074C
	for <issues@hbase.apache.org>; Thu, 27 Apr 2017 17:35:06 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -100.002
X-Spam-Level: 
X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31
	tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001,
	USER_IN_WHITELIST=-100] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024)
	with ESMTP id DFOoWAeurB1O for <issues@hbase.apache.org>;
	Thu, 27 Apr 2017 17:35:05 +0000 (UTC)
Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1A41C5FB3D
	for <issues@hbase.apache.org>; Thu, 27 Apr 2017 17:35:05 +0000 (UTC)
Received: from jira-lw-us.apache.org (unknown [207.244.88.139])
	by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 70125E0A31
	for <issues@hbase.apache.org>; Thu, 27 Apr 2017 17:35:04 +0000 (UTC)
Received: from jira-lw-us.apache.org (localhost [127.0.0.1])
	by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2A8B521DE1
	for <issues@hbase.apache.org>; Thu, 27 Apr 2017 17:35:04 +0000 (UTC)
Date: Thu, 27 Apr 2017 17:35:04 +0000 (UTC)
From: "Chia-Ping Tsai (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13062203.1491503671000.68866.1493314504172@Atlassian.JIRA>
In-Reply-To: <JIRA.13062203.1491503671000@Atlassian.JIRA>
References: <JIRA.13062203.1491503671000@Atlassian.JIRA> <JIRA.13062203.1491503671886@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-17887) TestAcidGuarantees fails
 frequently
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Thu, 27 Apr 2017 17:35:08 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987115#comment-15987115 ] 

Chia-Ping Tsai commented on HBASE-17887:
----------------------------------------

The store file created by lastest MemStore flush may not be loaded when the StoreScanner updates the scanner.
{code}
@Override
  public void updateReaders(List<StoreFile> sfs) throws IOException {
    flushed = true;
    flushLock.lock();
    try {
      flushedStoreFiles.addAll(sfs);
    } finally {
      flushLock.unlock();
    }
    // Let the next() call handle re-creating and seeking
  }
{code}
{code}
  protected void resetScannerStack(Cell lastTopKey) throws IOException {
    List<KeyValueScanner> scanners = null;
    try {
      flushLock.lock();
      scanners = selectScannersFrom(store.getScanners(flushedStoreFiles, cacheBlocks, get,
        scanUsePread, false, matcher, scan.getStartRow(), scan.getStopRow(), this.readPt, true));
      // Clear the current set of flushed store files so that they don't get added again
      flushedStoreFiles.clear();
    } finally {
      flushLock.unlock();
    }
{code}
If the flush size is smaller, the memStore may be flushed again before the StoreScanner calls resetScannerStack. The hfile of the latest MemStore isn't in flushedStoreFiles, so the data located in the latest MemStore will be lost in current scan.

> TestAcidGuarantees fails frequently
> -----------------------------------
>
>                 Key: HBASE-17887
>                 URL: https://issues.apache.org/jira/browse/HBASE-17887
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 2.0.0
>            Reporter: Umesh Agashe
>            Priority: Blocker
>
> As per the flaky tests dashboard here: https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html, It fails 30% of the time.
> While working on HBASE-17863, a few verification builds on patch failed due to TestAcidGuarantees didn't pass. IMHO, the changes for HBASE-17863 are unlikely to affect get/ put path.
> I ran the test with and without the patch several times locally and found that TestAcidGuarantees fails without the patch similar number of times.
> Opening blocker, considering acid guarantees are critical to HBase.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)