Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 5 Apr 2017 16:21:41 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13061398.1491300742000.212176.1491409301630@Atlassian.JIRA>
In-Reply-To: <JIRA.13061398.1491300742000@Atlassian.JIRA>
References: <JIRA.13061398.1491300742000@Atlassian.JIRA> <JIRA.13061398.1491300742290@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-17872) The MSLABImpl generates the
 invaild cells when unsafe is not availble
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 05 Apr 2017 16:21:46 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957143#comment-15957143 ] 

Ted Yu commented on HBASE-17872:
--------------------------------

lgtm

Consider introducing trivial change in hbase-server module to run tests.

> The MSLABImpl generates the invaild cells when unsafe is not availble
> ---------------------------------------------------------------------
>
>                 Key: HBASE-17872
>                 URL: https://issues.apache.org/jira/browse/HBASE-17872
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17872.v0.patch
>
>
> We will get the wrong position of buffer in multithreaded environment, so the method makes the invalid cell in MSLAB.
> {noformat}
>   public static int copyFromBufferToBuffer(ByteBuffer in, ByteBuffer out, int sourceOffset,
>       int destinationOffset, int length) {
>     if (in.hasArray() && out.hasArray()) {
>       // ...
>     } else if (UNSAFE_AVAIL) {
>       // ...
>     } else {
>       int outOldPos = out.position();
>       out.position(destinationOffset);
>       ByteBuffer inDup = in.duplicate();
>       inDup.position(sourceOffset).limit(sourceOffset + length);
>       out.put(inDup);
>       out.position(outOldPos);
>     }
>     return destinationOffset + length;
>   }
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)