Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 4 Apr 2017 12:48:41 +0000 (UTC)
From: "Chia-Ping Tsai (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13061398.1491300742000.200491.1491310121588@Atlassian.JIRA>
In-Reply-To: <JIRA.13061398.1491300742000@Atlassian.JIRA>
References: <JIRA.13061398.1491300742000@Atlassian.JIRA> <JIRA.13061398.1491300742290@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-17872) Make BBU#copyFromBufferToBuffer
 thread-safe
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 04 Apr 2017 12:48:48 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955097#comment-15955097 ] 

Chia-Ping Tsai commented on HBASE-17872:
----------------------------------------

The unsafe doesn't effect the position in BBU, but the others may effect the position. We should unify the logic of all methods in BBU.

> Make BBU#copyFromBufferToBuffer thread-safe
> -------------------------------------------
>
>                 Key: HBASE-17872
>                 URL: https://issues.apache.org/jira/browse/HBASE-17872
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> A case is shown below.
> We will get the wrong position of buffer in multithreaded environment, so the method makes the invalid cell in MSLAB.
> {noformat}
>   public static int copyFromBufferToBuffer(ByteBuffer in, ByteBuffer out, int sourceOffset,
>       int destinationOffset, int length) {
>     if (in.hasArray() && out.hasArray()) {
>       // ...
>     } else if (UNSAFE_AVAIL) {
>       // ...
>     } else {
>       int outOldPos = out.position();
>       out.position(destinationOffset);
>       ByteBuffer inDup = in.duplicate();
>       inDup.position(sourceOffset).limit(sourceOffset + length);
>       out.put(inDup);
>       out.position(outOldPos);
>     }
>     return destinationOffset + length;
>   }
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)