Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 1 Apr 2017 01:30:41 +0000 (UTC)
From: "JC (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13060790.1490992119000.181779.1491010241747@Atlassian.JIRA>
In-Reply-To: <JIRA.13060790.1490992119000@Atlassian.JIRA>
References: <JIRA.13060790.1490992119000@Atlassian.JIRA> <JIRA.13060790.1490992119774@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-17862) Condition that always returns true
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 01 Apr 2017 01:30:47 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951903#comment-15951903 ] 

JC commented on HBASE-17862:
----------------------------

Thanks for the comment. I've create a pull request: https://github.com/apache/hbase/pull/47

Thanks!

> Condition that always returns true
> ----------------------------------
>
>                 Key: HBASE-17862
>                 URL: https://issues.apache.org/jira/browse/HBASE-17862
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>            Reporter: JC
>            Priority: Trivial
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path: hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209 
> 210     ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211     if (this.columnOffset != null) {
> 212       return this.getLimit() == this.getLimit() &&
> 213           Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214     }
> {code}
> It should be?
> {code}
> 212       return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return value but wanted to report just in case.
> Thanks!


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)