Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id ED7FF200C63 for ; Thu, 27 Apr 2017 05:50:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EA9E2160BBB; Thu, 27 Apr 2017 03:50:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 47569160BA8 for ; Thu, 27 Apr 2017 05:50:08 +0200 (CEST) Received: (qmail 16225 invoked by uid 500); 27 Apr 2017 03:50:07 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 16212 invoked by uid 99); 27 Apr 2017 03:50:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Apr 2017 03:50:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D54AD1B0CE3 for ; Thu, 27 Apr 2017 03:50:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id FBqckZeSZAcg for ; Thu, 27 Apr 2017 03:50:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 800955FB38 for ; Thu, 27 Apr 2017 03:50:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CEF78E0C0D for ; Thu, 27 Apr 2017 03:50:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 336F221DE3 for ; Thu, 27 Apr 2017 03:50:04 +0000 (UTC) Date: Thu, 27 Apr 2017 03:50:04 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17448) Export metrics from RecoverableZooKeeper MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 27 Apr 2017 03:50:09 -0000 [ https://issues.apache.org/jira/browse/HBASE-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985953#comment-15985953 ] Hudson commented on HBASE-17448: -------------------------------- FAILURE: Integrated in Jenkins build HBase-1.4 #705 (See [https://builds.apache.org/job/HBase-1.4/705/]) HBASE-17448 Export metrics from RecoverableZooKeeper (apurtell: rev defc25c6d109c4c8782477cc517d71206e7d3aca) * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMetricsListener.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/MetricsZooKeeper.java * (add) hbase-hadoop2-compat/src/main/resources/META-INF/services/org.apache.hadoop.hbase.zookeeper.MetricsZooKeeperSource * (add) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/zookeeper/MetricsZooKeeperSource.java * (edit) hbase-client/pom.xml * (add) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/zookeeper/MetricsZooKeeperSourceImpl.java * (add) hbase-client/src/test/java/org/apache/hadoop/hbase/zookeeper/TestMetricsZooKeeper.java * (add) hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/zookeeper/TestMetricsZooKeeperSourceImpl.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java * (add) hbase-hadoop-compat/src/test/java/org/apache/hadoop/hbase/zookeeper/TestMetricsZooKeeperSource.java > Export metrics from RecoverableZooKeeper > ---------------------------------------- > > Key: HBASE-17448 > URL: https://issues.apache.org/jira/browse/HBASE-17448 > Project: HBase > Issue Type: Improvement > Components: Zookeeper > Affects Versions: 1.3.1 > Reporter: Andrew Purtell > Assignee: Chinmay Kulkarni > Labels: patch > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-17448-branch-1.patch, HBASE-17448.patch, HBASE-17448.patch > > > Consider adding instrumentation to RecoverableZooKeeper that exposes metrics on the performance and health of the embedded ZooKeeper client: latency histograms for each op type, number of reconnections, number of ops where a reconnection was necessary to proceed, number of failed ops due to CONNECTIONLOSS, number of failed ops due to SESSIONEXIPRED, number of failed ops due to OPERATIONTIMEOUT. > RecoverableZooKeeper is a class in hbase-client so we can hook up the new metrics to both client- and server-side metrics reporters. Probably this metrics source should be a process singleton. -- This message was sent by Atlassian JIRA (v6.3.15#6346)