Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EE5E8200C5C for ; Thu, 6 Apr 2017 06:03:46 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E7A15160B9E; Thu, 6 Apr 2017 04:03:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 141CF160B94 for ; Thu, 6 Apr 2017 06:03:45 +0200 (CEST) Received: (qmail 72181 invoked by uid 500); 6 Apr 2017 04:03:45 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 72164 invoked by uid 99); 6 Apr 2017 04:03:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Apr 2017 04:03:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A13ADC0115 for ; Thu, 6 Apr 2017 04:03:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id rQU8msob6_Xh for ; Thu, 6 Apr 2017 04:03:42 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5C02F5FBA1 for ; Thu, 6 Apr 2017 04:03:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D6828E036E for ; Thu, 6 Apr 2017 04:03:41 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8D0E624066 for ; Thu, 6 Apr 2017 04:03:41 +0000 (UTC) Date: Thu, 6 Apr 2017 04:03:41 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16469) Several log refactoring/improvement suggestions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 06 Apr 2017 04:03:47 -0000 [ https://issues.apache.org/jira/browse/HBASE-16469?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D159= 58252#comment-15958252 ]=20 Hadoop QA commented on HBASE-16469: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 36s = {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} = 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color= } | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m= 0s {color} | {color:green} The patch does not contain any @author tags. {c= olor} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green}= 0m 0s {color} | {color:green} The patch appears to include 2 new or modifi= ed test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 25s = {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 3m 38s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m= 23s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 1m 17s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}= 0m 43s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3= m 0s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m= 58s {color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s = {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 1m 18s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m= 10s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 1= 0s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 1m 8s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}= 0m 37s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green}= 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} = | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green= } 27m 20s {color} | {color:green} Patch does not cause any errors with Hado= op 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color}= | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2= m 52s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m= 51s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 16= s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 103m 16s {c= olor} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 24= s {color} | {color:green} hbase-it in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green}= 0m 54s {color} | {color:green} The patch does not generate ASF License war= nings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 154m 56s {co= lor} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=3D1.12.3 Server=3D1.12.3 Image:yetus/hbase:8d52d23 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1286221= 0/HBASE-16469.master.001.patch | | JIRA Issue | HBASE-16469 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck= hbaseanti checkstyle compile | | uname | Linux 6fd2ce626c45 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 1= 5:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build= @2/component/dev-support/hbase-personality.sh | | git revision | master / 029fa29 | | Default Java | 1.8.0_121 | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/6345/artifact/= patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/6345/= testReport/ | | modules | C: hbase-client hbase-server hbase-it U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/6345= /console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Several log refactoring/improvement suggestions > ----------------------------------------------- > > Key: HBASE-16469 > URL: https://issues.apache.org/jira/browse/HBASE-16469 > Project: HBase > Issue Type: Improvement > Components: Operability > Affects Versions: 1.2.5 > Reporter: Nemo Chen > Assignee: Nemo Chen > Labels: easyfix, easytest > Fix For: 2.0.0, 1.5.0 > > Attachments: HBASE-16469.master.001.patch > > > *method invocation replaced by variable* > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/C= loseRegionHandler.java > {code}String name =3D regionInfo.getRegionNameAsString();{code} > {code}LOG.warn("Can't close region: was already closed during close(): " = + > regionInfo.getRegionNameAsString()); {code} > In the above two examples, the method invocations are assigned to the var= iables before the logging code. These method invocations should be replaced= by variables in case of simplicity and readability > ---- > *method invocation in return statement* > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.j= ava > {code} > public String toString() { > return getRegionInfo().getRegionNameAsString(); > } > {code} > {code} > LOG.debug("Region " + getRegionInfo().getRegionNameAsString() > + " is not mergeable because it is closing or closed"); > {code} > {code} > LOG.debug("Region " + getRegionInfo().getRegionNameAsString() > + " is not mergeable because it has references"); > {code} > {code}=20 > LOG.info("Running close preflush of " + getRegionInfo().getRegionNameAsSt= ring()); > {code} > In these above examples, the "getRegionInfo().getRegionNameAsString())" i= s the return statement of method "toString" in the same class. They should = be replaced with =E2=80=9Cthis=E2=80=9D in case of simplicity and readabi= lity. > ---- > *check the logged variable if it is null* > hbase-it/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java > {code} > if ((sshUserName !=3D null && sshUserName.length() > 0) || > (sshOptions !=3D null && sshOptions.length() > 0)) { > LOG.info("Running with SSH user [" + sshUserName + "] and options [= " + sshOptions + "]"); > } > {code} > hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManag= er.java > {code} > if ((regionState =3D=3D null && latestState !=3D null) > || (regionState !=3D null && latestState =3D=3D null) > || (regionState !=3D null && latestState !=3D null > && latestState.getState() !=3D regionState.getState())) { > LOG.warn("Region state changed from " + regionState + " to " > + latestState + ", while acquiring lock"); > } > {code} > In the above example, the logging variable could null at run time. It is = a bad practice to include null variables inside logs. > ---- > *variable in byte printed directly* > hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpda= ter.java > {code} > byte[] rowKey =3D dataGenerator.getDeterministicUniqueKey(rowKeyBase); > {code} > {code} > LOG.error("Failed to update the row with key =3D [" + rowKey > + "], since we could not get the original row"); > {code} > rowKey should be printed as Bytes.toString(rowKey). > ----=20 > *object toString contain mi* > The toString method returns getServerName(), so the "server.getServerName= ()" should be replaced with "server" in case of simplicity and readability. > hbase-client/src/main/java/org/apache/hadoop/hbase/client/PreemptiveFastF= ailInterceptor.java > {code} > LOG.info("Clearing out PFFE for server " + server.getServerName()); > return getServerName(); > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)