hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17933) [hbase-spark] Support Java api for bulkload
Date Wed, 19 Apr 2017 15:10:42 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974880#comment-15974880

Sean Busbey commented on HBASE-17933:

34	import java.util.HashMap;
35	import java.util.List;
37	final public class JavaHBaseBulkLoadExample {
38	  private JavaHBaseBulkLoadExample() {}

Please include a class javadoc that gives a brief description the purpose of the example,
includes one or more sample spark-submit lines for running it, and lets folks know how they
would verify that it ran correctly.

70	  /**
71	  * This is a wrapper class for FamiliesQualifiersValues above
72	  * mainly used to support Java BulkLoad API
73	  */
74	class KeyFamiliesQualifiersValues(rowkey: ByteArrayWrapper, columnAndValue: FamiliesQualifiersValues)
75	  extends Serializable {

Why not make this its own file? AFAICT it's not an inner class of FamiliesQualifiersValues,
and putting additional top-level classes in the same source file is likely to lead to confusing
mistakes in the future (like compile order of source files mattering for wether or not this
class can be found).

Also, this class needs an InterfaceAudience annotation.

50	/**
51	 * This is a wrapper class for KeyFamilyQualifier
52	 * mainly used to support Java BulkLoad API
53	 */
54	class KeyFamilyQualifierValue (val key:Array[Byte], val fam:Array[Byte], val qual:Array[Byte],
val value:Array[Byte])

Same concern as with {{KeyFamiliesQualifiersValues}}.


Looks like some formatting changes in here not related to the proposed issue here, could you
leave them out?


There's some nice cleanup in here, but it also looks unrelated to the proposal here. Could
you break that into a different issue?

> [hbase-spark]  Support Java api for bulkload
> --------------------------------------------
>                 Key: HBASE-17933
>                 URL: https://issues.apache.org/jira/browse/HBASE-17933
>             Project: HBase
>          Issue Type: New Feature
>          Components: spark
>    Affects Versions: 2.0.0
>            Reporter: Yi Liang
>            Assignee: Yi Liang
>             Fix For: 2.0.0
>         Attachments: HBase-17933-V1.patch
> In JavaHBaseContext, there are java api for bulkPut, bulkDelete ...., but no Java api
for bulkload. And this jira will add bulkload java api to hbase-spark

This message was sent by Atlassian JIRA

View raw message