hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17888) Add generic methods for updating metrics on start and end of a procedure execution
Date Thu, 13 Apr 2017 04:16:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967098#comment-15967098
] 

stack commented on HBASE-17888:
-------------------------------

Patch looks good.

I'll fix this stuff on commit in javadoc: 'e - R'; i.e. the hyphen between param name and
description. It comes out wonky when you render.

I was going to add note that currently we need to do start and finish in two places but will
be addressed in a follow-on. That right?

Thanks [~uagashe]

You good [~appy]?



> Add generic methods for updating metrics on start and end of a procedure execution
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-17888
>                 URL: https://issues.apache.org/jira/browse/HBASE-17888
>             Project: HBase
>          Issue Type: Improvement
>          Components: proc-v2
>            Reporter: Umesh Agashe
>            Assignee: Umesh Agashe
>         Attachments: HBASE-17888.v1.patch, HBASE-17888.v2.patch
>
>
> For all procedures in Procv2 framework, Procedure class can have generic methods to update
metrics on start and end of a procedure execution. Specific procedure can override these and
implement/ update respective metrics. Default implementation needs to be provided so override
and implementation is optional.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message